Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add environment-agnostic ci/run_cudf_polars_pytest.sh #16178

Merged
merged 1 commit into from
Jul 3, 2024
Merged

Add environment-agnostic ci/run_cudf_polars_pytest.sh #16178

merged 1 commit into from
Jul 3, 2024

Conversation

trxcllnt
Copy link
Contributor

@trxcllnt trxcllnt commented Jul 2, 2024

Adds environment-agnostic ci/run_cudf_polars_pytest.sh script, similar to the scripts added in #14992.

@trxcllnt trxcllnt requested a review from a team as a code owner July 2, 2024 19:26
@trxcllnt trxcllnt requested a review from raydouglass July 2, 2024 19:26
@trxcllnt trxcllnt added 3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jul 2, 2024
jameslamb
jameslamb approved these changes Jul 3, 2024
View reviewed changes
Copy link
Member

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Giving you a packaging-codeowners approval, this makes sense to me and I understand why we want these scripts to be environment-agnostic (for e.g. DLFW builds).

@bdice bdice mentioned this pull request Jul 3, 2024
Merged
3 tasks
@trxcllnt
Copy link
Contributor Author

trxcllnt commented Jul 3, 2024

/merge

@rapids-bot rapids-bot bot merged commit dab6a44 into rapidsai:branch-24.08 Jul 3, 2024
76 checks passed
@trxcllnt trxcllnt deleted the fix/cudf-polars-test-script branch July 3, 2024 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jameslamb jameslamb jameslamb approved these changes

@raydouglass raydouglass Awaiting requested review from raydouglass raydouglass is a code owner automatically assigned from rapidsai/ci-codeowners

Assignees
No one assigned
Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trxcllnt @jameslamb