Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Build wheels for cudf-polars #16156

Merged
merged 19 commits into from
Jul 5, 2024
Merged

CI: Build wheels for cudf-polars #16156

merged 19 commits into from
Jul 5, 2024

Conversation

lithomas1
Copy link
Contributor

@lithomas1 lithomas1 commented Jul 2, 2024 •
edited
Loading

Description

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

TODO: wheel publishing (followup)

@github-actions github-actions bot added Python Affects Python cuDF API. cudf.polars Issues specific to cudf.polars labels Jul 2, 2024
bdice
bdice reviewed Jul 2, 2024
View reviewed changes
.github/workflows/pr.yaml Outdated Show resolved Hide resolved
.github/workflows/pr.yaml Outdated Show resolved Hide resolved
ci/test_wheel_cudf_polars.sh Show resolved Hide resolved
@github-actions github-actions bot removed Python Affects Python cuDF API. cudf.polars Issues specific to cudf.polars labels Jul 2, 2024
@github-actions github-actions bot added Python Affects Python cuDF API. cudf.polars Issues specific to cudf.polars labels Jul 3, 2024
@lithomas1 lithomas1 marked this pull request as ready for review July 3, 2024 14:51
@lithomas1 lithomas1 requested review from a team as code owners July 3, 2024 14:51
@lithomas1 lithomas1 requested a review from AyodeAwe July 3, 2024 14:51
@lithomas1 lithomas1 changed the title Test polars packaging CI: Build wheels for cudf-polars Jul 3, 2024
@lithomas1 lithomas1 requested a review from bdice July 3, 2024 14:51
@lithomas1 lithomas1 added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jul 3, 2024
wence-
wence- reviewed Jul 3, 2024
View reviewed changes
ci/test_wheel_cudf_polars.sh Outdated Show resolved Hide resolved
@lithomas1
Copy link
Contributor Author

One thing I'm not doing is this PR is making conda packages yet.

(I'll probably do that in a followup. Let me know if you want that here as well).

@bdice
Copy link
Contributor

bdice commented Jul 3, 2024

One thing I'm not doing is this PR is making conda packages yet.

(I'll probably do that in a followup. Let me know if you want that here as well).

It's okay to do one at a time. Conda in a follow-up should be fine.

bdice
bdice approved these changes Jul 3, 2024
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good to me. I also inspected the wheels to make sure they conform to my expectations. Approving! Conda packages in a follow-up would be appreciated. Also be aware of #16178 which may conflict.

@lithomas1
Copy link
Contributor Author

Planning on self-merging this soon, as cudf-polars CI is green, and since this should be relatively harmless (doesn't upload wheels).

Happy to address further comments in a followup.

@lithomas1
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 7dd6945 into rapidsai:branch-24.08 Jul 5, 2024
80 checks passed
@lithomas1 lithomas1 deleted the test-polars-packaging branch July 5, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wence- wence- wence- left review comments

@bdice bdice bdice approved these changes

@AyodeAwe AyodeAwe Awaiting requested review from AyodeAwe AyodeAwe is a code owner automatically assigned from rapidsai/packaging-codeowners

Assignees
No one assigned
Labels
cudf.polars Issues specific to cudf.polars improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
cuDF Python
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lithomas1 @bdice @wence-