Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a size overflow bug in hash groupby #16053

Merged
merged 4 commits into from
Jun 18, 2024
Merged

Fix a size overflow bug in hash groupby #16053

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a38e5bf
Fix a size overflow bug in hash groupby
PointKernel Jun 17, 2024
6f88bfc
Fix a docstring sort bug
PointKernel Jun 17, 2024
b7c985d
Fix a java test bug: sort before compare
PointKernel Jun 18, 2024
fa26c65
Merge remote-tracking branch 'upstream/branch-24.08' into fix-groupby…
PointKernel Jun 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion cpp/src/groupby/hash/groupby.cu
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -553,7 +553,8 @@ std::unique_ptr<table> groupby(table_view const& keys,
rmm::cuda_stream_view stream,
rmm::device_async_resource_ref mr)
{
auto const num_keys = keys.num_rows();
// convert to int64_t to avoid potential overflow with large `keys`
auto const num_keys = static_cast<int64_t>(keys.num_rows());
auto const null_keys_are_equal = null_equality::EQUAL;
auto const has_null = nullate::DYNAMIC{cudf::has_nested_nulls(keys)};

Expand Down
Loading