Fix a size overflow bug in hash groupby #16053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PointKernel
added
bug
bdice
approved these changes
Jun 17, 2024
3 tasks
mroeschke
approved these changes
Jun 18, 2024
ttnghia
approved these changes
Jun 18, 2024
|
@ttnghia Thanks for helping fix the Java test! |
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a size overflow bug discovered by @matal-nvidia. It converts the groupby problem size to
int64_tso it won't overflow if larger thanINT_MAX / 2with 50% hash table occupancy.Unit tests for this scenario will saturate device memory and take longer than necessary, making them likely not worth adding.
Checklist