Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project automation bug fixes #15971

Merged

Conversation

jarmak-nv
Copy link
Contributor

@jarmak-nv jarmak-nv commented Jun 11, 2024

Description

This PR resolves two bugs in the recent pr #15945

external issue labeling

Recent runs show that it is labeling issues created by team members as External

Using graphQL to explore the authorAssociation shows "authorAssociation": "MEMBER" - I've updated the permissions to be specific to the job in an attempt to ensure that we have the permissions we need. Testing this action in personal repos shows it works as expected so not 100% on what's going on.

A PR was also unable to run due to the token only having read permissions, so hopefully this is a two birds one stone fix.

It may be beneficial to re-run https://github.com/rapidsai/cudf/actions/runs/9462546964/job/26065765728 with debug mode on to see if author_association is different to the action (which would be concerning)

edit test

project automation

This fixes the workflow incorrectly calling my personal workflows for testing.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@jarmak-nv jarmak-nv requested a review from a team as a code owner June 11, 2024 15:42
@jarmak-nv jarmak-nv requested a review from KyleFromNVIDIA June 11, 2024 15:42
@jarmak-nv jarmak-nv marked this pull request as draft June 11, 2024 16:27
@jarmak-nv jarmak-nv added non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels Jun 11, 2024
@jarmak-nv jarmak-nv marked this pull request as ready for review June 11, 2024 16:54
@AyodeAwe AyodeAwe merged commit d844d67 into rapidsai:branch-24.08 Jun 11, 2024
24 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants