Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add external issue label and project automation #15945

Merged

Conversation

jarmak-nv
Copy link
Contributor

Description

This PR creates two new GitHub Actions around issue and PR tracking

external_issue_labeler.yml

This action automatically adds a label, currently External, to any issue or PR that is opened by someone that is not either an owner, member, or collaborator to the cuDF repo

pr_issue_status_automation.yml

This action uses the shared workflows in rapdsai/shared-workflows to, on open/edit/synchronize of an open PR, to:

  1. Set the PR to in progress
  2. Set all linked issues in progress
  3. Set the PR's sprint to the current iteration
  4. Set all linked issues to the current iteration

Edit triggers on edit of the PR description, (so new linked issues will get synchronized to in progress). Synchronize triggers on push and rebase events - this really is to cover the "what are we working on right now" because anything we touch goes into the current sprint in the project.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@jarmak-nv jarmak-nv requested a review from a team as a code owner June 6, 2024 18:26
@jarmak-nv jarmak-nv requested a review from bdice June 6, 2024 18:26
@vyasr vyasr added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jun 7, 2024
@vyasr
Copy link
Contributor

vyasr commented Jun 11, 2024

/merge

@rapids-bot rapids-bot bot merged commit 1bd210d into rapidsai:branch-24.08 Jun 11, 2024
69 checks passed
@jarmak-nv jarmak-nv mentioned this pull request Jun 11, 2024
3 tasks
AyodeAwe pushed a commit that referenced this pull request Jun 11, 2024
## Description
This PR resolves two bugs in the recent pr #15945

## external issue labeling
Recent runs show that it is labeling [issues
created](#15967) by team members
as `External`

Using graphQL to explore the authorAssociation shows
`"authorAssociation": "MEMBER"` - I've updated the permissions to be
specific to the job in an attempt to ensure that we have the permissions
we need. Testing this action in personal repos shows it works as
expected so not 100% on what's going on.

A PR was also unable to run due to the token only having read
permissions, so hopefully this is a two birds one stone fix.

It may be beneficial to re-run
https://github.com/rapidsai/cudf/actions/runs/9462546964/job/26065765728
with debug mode on to see if `author_association` is different to the
action (which would be concerning)

*edit test*

## project automation
This fixes the workflow incorrectly calling my personal workflows for
testing.


## Checklist
- [x] I am familiar with the [Contributing
Guidelines](https://github.com/rapidsai/cudf/blob/HEAD/CONTRIBUTING.md).
- [ ] ~New or existing tests cover these changes.~
- [ ] ~The documentation is up to date with these changes.~
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants