Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate left join and conditional join benchmarks to use nvbench #15931

Merged
merged 3 commits into from
Jun 11, 2024
Merged

Migrate left join and conditional join benchmarks to use nvbench #15931

merged 3 commits into from
Jun 11, 2024

Conversation

srinivasyadav18
Copy link
Contributor

@srinivasyadav18 srinivasyadav18 commented Jun 5, 2024 •
edited
Loading

Description

The current left join and conditional join benchmarks are still using gbench.
This PR migrates the left join and conditional join benchmarks to use nvbench.

Closes #15699.

  • Migrate from gbench to nvbench
  • Similar to Clean up join benchmarks #15644, use JOIN_KEY_TYPE_RANGE, JOIN_NULLABLE_RANGE and JOIN_SIZE_RANGE to reduce the number of test cases and simplify the implementation
  • Get rid of the dispatching between gbench and nvbench in join_common.hpp

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@srinivasyadav18 srinivasyadav18 requested a review from a team as a code owner June 5, 2024 19:16
@srinivasyadav18 srinivasyadav18 requested review from vyasr and shrshi June 5, 2024 19:16
@github-actions github-actions bot added libcudf Affects libcudf (C++/CUDA) code. CMake CMake build issue labels Jun 5, 2024
@srinivasyadav18 srinivasyadav18 added feature request New feature or request non-breaking Non-breaking change labels Jun 5, 2024
PointKernel
PointKernel approved these changes Jun 5, 2024
View reviewed changes
Copy link
Member

@PointKernel PointKernel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGreatTM

cpp/benchmarks/join/join_common.hpp
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

#include <benchmarks/synchronization/synchronization.hpp>

non-blocking nit: this inclusion is probably no longer needed.

@PointKernel
Copy link
Member

/merge

@rapids-bot rapids-bot bot merged commit ff1e4bb into rapidsai:branch-24.08 Jun 11, 2024
71 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PointKernel PointKernel PointKernel approved these changes

@shrshi shrshi shrshi approved these changes

@vyasr vyasr vyasr approved these changes

Assignees
No one assigned
Labels
CMake CMake build issue feature request New feature or request libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEA] Migrate left join and conditional join benchmarks to use nvbench
4 participants
@srinivasyadav18 @PointKernel @vyasr @shrshi