[FEA] Migrate left join and conditional join benchmarks to use nvbench #15699
Assignees
Labels
feature request
New feature or request
good first issue
Good for newcomers
libcudf
Affects libcudf (C++/CUDA) code.
Comments
PointKernel
added
feature request
6 tasks
rapids-bot bot
pushed a commit
that referenced
this issue
Jun 11, 2024
) The current [left join](https://github.com/rapidsai/cudf/blob/580ee40bf5fe1a66eaba914cdddb718a09193bab/cpp/benchmarks/join/left_join.cu) and [conditional join](https://github.com/rapidsai/cudf/blob/580ee40bf5fe1a66eaba914cdddb718a09193bab/cpp/benchmarks/join/conditional_join.cu) benchmarks are still using gbench. This PR migrates the **left join** and **conditional join** benchmarks to use **nvbench**. Closes #15699. - [x] Migrate from gbench to nvbench - [x] Similar to #15644, use `JOIN_KEY_TYPE_RANGE`, `JOIN_NULLABLE_RANGE` and `JOIN_SIZE_RANGE` to reduce the number of test cases and simplify the implementation - [x] Get rid of the dispatching between gbench and nvbench in [join_common.hpp](https://github.com/rapidsai/cudf/blob/580ee40bf5fe1a66eaba914cdddb718a09193bab/cpp/benchmarks/join/join_common.hpp) Authors: - Srinivas Yadav (https://github.com/srinivasyadav18) - Yunsong Wang (https://github.com/PointKernel) Approvers: - Yunsong Wang (https://github.com/PointKernel) - Shruti Shivakumar (https://github.com/shrshi) - Vyas Ramasubramani (https://github.com/vyasr) URL: #15931
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
and others
Is your feature request related to a problem? Please describe.
The current left join and conditional join benchmarks are still using gbench. We should migrate them to use nvbench for simplicity and consistency.
Describe the solution you'd like
TODO:
JOIN_KEY_TYPE_RANGE,JOIN_NULLABLE_RANGEandJOIN_SIZE_RANGEto reduce the number of test cases and simplify the implementationThe text was updated successfully, but these errors were encountered: