Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Frame._dtype an iterator instead of a dict #15920

Merged
merged 3 commits into from
Jun 5, 2024
Merged

Make Frame._dtype an iterator instead of a dict #15920

merged 3 commits into from
Jun 5, 2024

Conversation

mroeschke
Copy link
Contributor

@mroeschke mroeschke commented Jun 4, 2024 •
edited
Loading

Description

A lot of the usages of Frame._dtype didn't require the previous dict return type since that was just re-iterated over anyways.

Also removed a redundant tuple call in Frame._column_names and Frame._columns

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@mroeschke mroeschke added Python Affects Python cuDF API. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jun 4, 2024
@mroeschke mroeschke requested a review from a team as a code owner June 4, 2024 19:32
@mroeschke mroeschke changed the title Clean Frame._dtype usage Make Frame._dtype and iterator instead of a dict Jun 4, 2024
@mroeschke mroeschke changed the title Make Frame._dtype and iterator instead of a dict Make Frame._dtype an iterator instead of a dict Jun 5, 2024
@mroeschke
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 57aeeb7 into rapidsai:branch-24.08 Jun 5, 2024
70 checks passed
@mroeschke mroeschke deleted the ref/_dtypes branch June 5, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wence- wence- wence- approved these changes

@charlesbluca charlesbluca Awaiting requested review from charlesbluca charlesbluca is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@brandon-b-miller brandon-b-miller Awaiting requested review from brandon-b-miller brandon-b-miller is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees
No one assigned
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mroeschke @wence-