Use rapids_cpm_nvtx3 to get same nvtx3 target state as rmm #15840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertmaynard
added
bug
|
Blocked by rapidsai/rapids-cmake#617 |
github-actions
bot
added
libcudf
vyasr
approved these changes
May 23, 2024
ttnghia
approved these changes
May 23, 2024
robertmaynard
force-pushed
the
bug/correct_nvxt3_static_builds
branch
from
361ffae to
fe6dd58
Compare
robertmaynard
force-pushed
the
bug/correct_nvxt3_static_builds
branch
from
8abfd6d to
fadfe0f
Compare
3 tasks
jlowe
approved these changes
May 23, 2024
ttnghia
approved these changes
May 23, 2024
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We need to use the
rapids_cpm_nvtx3so that the nvtx3 targets, and setup are consistent across rmm and cudf. If we don't we get errors around incorrect exports when building statically or link errors when building shared.Checklist