Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NVTX3 dependency #2072

Merged
merged 2 commits into from
May 24, 2024
Merged

Fix NVTX3 dependency #2072

merged 2 commits into from
May 24, 2024

Conversation

jlowe
Copy link
Member

@jlowe jlowe commented May 24, 2024

Fixes the submodule sync error reported in #2067. Need to use the qualified nvtx3 name that was changed in rapidsai/cudf#15840.

Signed-off-by: Jason Lowe <[email protected]>
@jlowe jlowe added the build label May 24, 2024
@jlowe jlowe self-assigned this May 24, 2024
@jlowe
Copy link
Member Author

jlowe commented May 24, 2024

build

abellina
abellina previously approved these changes May 24, 2024
@abellina
Copy link
Collaborator

Failed with:

8:23:38  [INFO]      [exec] CMake Error at CMakeLists.txt:794 (target_link_libraries):
08:23:38  [INFO]      [exec]   Target "cudf" links to:
08:23:38  [INFO]      [exec] 
08:23:38  [INFO]      [exec]     nvtx3::nvtx3-cpp
08:23:38  [INFO]      [exec] 
08:23:38  [INFO]      [exec]   but the target was not found.  Possible reasons include:
08:23:38  [INFO]      [exec] 
08:23:38  [INFO]      [exec]     * There is a typo in the target name.
08:23:38  [INFO]      [exec]     * A find_package call is missing for an IMPORTED target.
08:23:38  [INFO]      [exec]     * An ALIAS target is missing.
08:23:38  [INFO]      [exec] 

@jlowe
Copy link
Member Author

jlowe commented May 24, 2024

Oops, forgot to update the rapids-cmake SHA. Fixed.

@jlowe
Copy link
Member Author

jlowe commented May 24, 2024

build

@jlowe jlowe merged commit a77db76 into NVIDIA:branch-24.06 May 24, 2024
3 checks passed
@jlowe jlowe deleted the fix-build branch May 24, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants