-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JNI] Expose java API for cudf::io::config_host_memory_resource #15745
Changes from 1 commit
cf8f211
c3b603f
8ba3671
1b09bd2
f087480
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -266,6 +266,14 @@ public static synchronized void initialize(int allocationMode, LogConf logConf, | |||||
} | ||||||
} | ||||||
|
||||||
/** | ||||||
* Sets the size of the cuDF default pinned pool. | ||||||
* | ||||||
* @note This has to be called before cuDF functions are executed. | ||||||
* @param size | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
*/ | ||||||
public static synchronized native void configureDefaultCudfPinnedPoolSize(long size); | ||||||
|
||||||
/** | ||||||
* Get the most recently set pool size or -1 if RMM has not been initialized or pooling is | ||||||
* not enabled. | ||||||
|
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -1106,4 +1106,16 @@ JNIEXPORT void JNICALL Java_ai_rapids_cudf_Rmm_freeFromFallbackPinnedPool(JNIEnv | |||||
} | ||||||
CATCH_STD(env, ) | ||||||
} | ||||||
|
||||||
JNIEXPORT void JNICALL Java_ai_rapids_cudf_Rmm_configureDefaultCudfPinnedPoolSize(JNIEnv* env, | ||||||
jclass clazz, | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Remove name of the unused var to avoid compile warning.
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We have this in every single API in this file and probably other, but I am not seeing warnings on it. I'd rather keep it as is at this stage. |
||||||
jlong size) | ||||||
{ | ||||||
cudf::io::config_host_memory_resource(size); | ||||||
try { | ||||||
cudf::jni::auto_set_device(env); | ||||||
cudf::io::config_host_memory_resource(size); | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Duplicate calls? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nice catch, this was a copy and paste error |
||||||
} | ||||||
CATCH_STD(env, ) | ||||||
} | ||||||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.