[JNI] Expose java API for cudf::io::config_host_memory_resource #15745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abellina
added
5 - DO NOT MERGE
ttnghia
reviewed
May 14, 2024
| * Sets the size of the cuDF default pinned pool. | ||
| * | ||
| * @note This has to be called before cuDF functions are executed. | ||
| * @param size |
There was a problem hiding this comment.
Suggested change
| * @param size | |
| * @param size ??? |
ttnghia
reviewed
May 14, 2024
| * Sets the size of the cuDF default pinned pool. | ||
| * | ||
| * @note This has to be called before cuDF functions are executed. | ||
| * @param size |
There was a problem hiding this comment.
Suggested change
| * @param size | |
| * @param size ??? |
ttnghia
reviewed
May 14, 2024
java/src/main/native/src/RmmJni.cpp
Outdated
Comment on lines
1114
to
1117
| cudf::io::config_host_memory_resource(size); | ||
| try { | ||
| cudf::jni::auto_set_device(env); | ||
| cudf::io::config_host_memory_resource(size); |
There was a problem hiding this comment.
nice catch, this was a copy and paste error
ttnghia
reviewed
May 17, 2024
| @@ -1106,4 +1106,15 @@ JNIEXPORT void JNICALL Java_ai_rapids_cudf_Rmm_freeFromFallbackPinnedPool(JNIEnv | |||
| } | |||
| CATCH_STD(env, ) | |||
| } | |||
|
|
|||
| JNIEXPORT void JNICALL Java_ai_rapids_cudf_Rmm_configureDefaultCudfPinnedPoolSize(JNIEnv* env, | |||
| jclass clazz, | |||
There was a problem hiding this comment.
Remove name of the unused var to avoid compile warning.
Suggested change
| jclass clazz, | |
| jclass, |
There was a problem hiding this comment.
We have this in every single API in this file and probably other, but I am not seeing warnings on it. I'd rather keep it as is at this stage.
ttnghia
approved these changes
May 17, 2024
|
/ok to test |
|
/okay to test |
|
/merge |
abellina
added a commit
to abellina/cudf
that referenced
this pull request
May 22, 2024
…ce (rapidsai#15745)" This reverts commit 8b72455.
abellina
added a commit
to abellina/cudf
that referenced
this pull request
May 22, 2024
…y_resource (rapidsai#15745)"" This reverts commit ff392b5.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR depends on #15665 and so it won't build until that PR merges.
Adds support for
cudf::io::config_host_memory_resourcewhich is being worked on in #15665. In 24.06 we are going to disable the cuDF pinned pool and look into this more in 24.08.We currently have a pinned pooled resource that has been setup to share pinned memory with other APIs we use from java, so we wanted to prevent extra pinned memory being created by default, and @vuule has added an API for us to call to accomplish this.