Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine CudaTest.testCudaException in case throwing wrong type of CudaError under aarch64 #15706

Merged
merged 3 commits into from
May 10, 2024
+4 −5
Merged

Refine CudaTest.testCudaException in case throwing wrong type of CudaError under aarch64 #15706

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
113c83a
Fix CudaTest.testCudaException over weird scenario
sperlingxx May 9, 2024
00358a3
Merge branch 'branch-24.06' into fix_testCudaException
sperlingxx May 10, 2024
ffaafb9
fix typo
sperlingxx May 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions java/src/test/java/ai/rapids/cudf/CudaTest.java
View file
Open in desktop
jlowe marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2021-2023, NVIDIA CORPORATION.
* Copyright (c) 2021-2024, NVIDIA CORPORATION.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand All @@ -16,7 +16,6 @@

package ai.rapids.cudf;

import org.junit.jupiter.api.Tag;
import org.junit.jupiter.api.Test;

import static org.junit.jupiter.api.Assertions.assertEquals;
Expand All @@ -34,13 +33,13 @@ public void testGetCudaRuntimeInfo() {
assertEquals(Cuda.getNativeComputeMode(), Cuda.getComputeMode().nativeId);
}

@Tag("noSanitizer")
@Test
public void testCudaException() {
assertThrows(CudaException.class, () -> {
try {
Cuda.memset(Long.MAX_VALUE, (byte) 0, 1024);
} catch (CudaFatalException ignored) {
Cuda.freePinned(-1L);
} catch (CudaFatalException fatalEx) {
throw new AssertionError("Expected UnFatalError but got FatalError: " + fatalEx);
} catch (CudaException ex) {
assertEquals(CudaException.CudaError.cudaErrorInvalidValue, ex.getCudaError());
throw ex;
Expand Down
Loading