Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refine CudaTest.testCudaException in case throwing wrong type of CudaError under aarch64 #15706

Merged
merged 3 commits into from
May 10, 2024
Merged

Refine CudaTest.testCudaException in case throwing wrong type of CudaError under aarch64 #15706

merged 3 commits into from
May 10, 2024

Conversation

sperlingxx
Copy link
Contributor

Fix #15705

  1. Replacing Cuda.memset(Long.MAX_VALUE, (byte) 0, 1024) with Cuda.freePinned(-1L), the previous one throws fatal CUDAError cudaErrorIllegalAddress instead of nonFatal CUDAError cudaErrorInvalidValue under aarch64, while the later one throwing the correct kind of error.

  2. Enable the test case when Sanitizer is ON

@sperlingxx sperlingxx requested a review from a team as a code owner May 9, 2024 09:39
@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented May 9, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions github-actions bot added the Java Affects Java cuDF API. label May 9, 2024
@sperlingxx sperlingxx mentioned this pull request May 9, 2024
Closed
@NvTimLiu NvTimLiu self-requested a review May 9, 2024 12:21
@NvTimLiu
Copy link
Contributor

NvTimLiu commented May 9, 2024

Verified on my local arm64 rocky8 container, unit tests can PASS!

@NvTimLiu
Copy link
Contributor

NvTimLiu commented May 9, 2024

/ok to test

@NvTimLiu NvTimLiu added non-breaking Non-breaking change bug Something isn't working labels May 9, 2024
@NvTimLiu NvTimLiu mentioned this pull request May 10, 2024
Merged
@jlowe
Copy link
Member

jlowe commented May 10, 2024

/ok to test

@jlowe
Copy link
Member

jlowe commented May 10, 2024

/merge

@rapids-bot rapids-bot bot merged commit e1c6dc2 into rapidsai:branch-24.06 May 10, 2024
70 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NvTimLiu NvTimLiu NvTimLiu approved these changes

@jlowe jlowe jlowe approved these changes

Assignees
No one assigned
Labels
bug Something isn't working Java Affects Java cuDF API. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
3 participants
@sperlingxx @NvTimLiu @jlowe