Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove experimental namespace from make_strings_children #15702

Merged
merged 1 commit into from
May 13, 2024
Merged

Remove experimental namespace from make_strings_children #15702

merged 1 commit into from
May 13, 2024

Conversation

davidwendt
Copy link
Contributor

Description

Replaces the cudf::strings::detail::make_strings_children with the new cudf::strings::detail::experimental::make_strings_children.
No code logic has changed -- just code moved around. All current code was already using the experimental function.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added 2 - In Progress Currently a work in progress libcudf Affects libcudf (C++/CUDA) code. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels May 8, 2024
@davidwendt davidwendt self-assigned this May 8, 2024
@davidwendt davidwendt added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels May 8, 2024
@davidwendt davidwendt marked this pull request as ready for review May 8, 2024 19:23
@davidwendt davidwendt requested a review from a team as a code owner May 8, 2024 19:23
mhaseeb123
mhaseeb123 approved these changes May 8, 2024
View reviewed changes
Copy link
Member

@mhaseeb123 mhaseeb123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@davidwendt
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit c42c418 into rapidsai:branch-24.06 May 13, 2024
71 checks passed
@davidwendt davidwendt deleted the promote-exp-msc branch May 13, 2024 12:06
@davidwendt davidwendt mentioned this pull request May 13, 2024
Closed
This was referenced May 13, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhaseeb123 mhaseeb123 mhaseeb123 approved these changes

@vyasr vyasr vyasr approved these changes

@hyperbolic2346 hyperbolic2346 Awaiting requested review from hyperbolic2346 hyperbolic2346 is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees

@davidwendt davidwendt

Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidwendt @vyasr @mhaseeb123