Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix string functors to adapt to the new make_strings_children from cudf #2034

Merged
merged 3 commits into from
May 13, 2024

Conversation

ttnghia
Copy link
Collaborator

@ttnghia ttnghia commented May 13, 2024

This fixes the string functors to adapt to the breaking changes made by rapidsai/cudf#15702.

Closes #2032.

Signed-off-by: Nghia Truong <[email protected]>
@ttnghia ttnghia requested a review from abellina May 13, 2024 16:57
@ttnghia ttnghia self-assigned this May 13, 2024
Signed-off-by: Nghia Truong <[email protected]>
@ttnghia
Copy link
Collaborator Author

ttnghia commented May 13, 2024

build

abellina
abellina previously approved these changes May 13, 2024
Signed-off-by: Nghia Truong <[email protected]>
@ttnghia
Copy link
Collaborator Author

ttnghia commented May 13, 2024

build

@ttnghia ttnghia merged commit 19d8d48 into NVIDIA:branch-24.06 May 13, 2024
3 checks passed
@ttnghia ttnghia deleted the fix_string branch May 13, 2024 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] string compilation failures around input_offsetalator and a missing member d_sizes
2 participants