Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add contributing warning about circular imports #15691

Merged
merged 7 commits into from
May 21, 2024
Merged

Add contributing warning about circular imports #15691

Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
04e4ca1
Add contributing warning about circular imports
er-eis May 7, 2024
d67ee9d
Merge branch 'branch-24.06' into er-eis/circular-import-contributing-…
er-eis May 7, 2024
93358c3
Better note message
er-eis May 9, 2024
1824627
Merge branch 'branch-24.06' into er-eis/circular-import-contributing-…
er-eis May 9, 2024
32ed858
Merge branch 'branch-24.06' into er-eis/circular-import-contributing-…
er-eis May 17, 2024
46583da
Clarify comment
er-eis May 19, 2024
4ea3bee
Merge branch 'branch-24.06' into er-eis/circular-import-contributing-…
er-eis May 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,6 +161,9 @@ To build all libraries and tests, with Python packages in development mode, simp
./build.sh --pydevelop libcudf libcudf_kafka cudf dask_cudf cudf_kafka custreamz
```

- **WARNING**: Various changes to files, such as .pyx and .pyd, may cause errors such as
circular imports until you build again.
vyasr marked this conversation as resolved.
Show resolved Hide resolved

To run the C++ tests, run

```bash
Expand Down
Loading