Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add contributing warning about circular imports #15691

Merged
merged 7 commits into from
May 21, 2024
Merged

Add contributing warning about circular imports #15691

merged 7 commits into from
May 21, 2024

Conversation

er-eis
Copy link
Contributor

@er-eis er-eis commented May 7, 2024

Description

Closes #15689

Adds warning to contributing doc regarding the necessity to rebuild and the type of error a developer may see

Checklist

@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented May 7, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

bdice
bdice reviewed May 7, 2024
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
@mroeschke mroeschke added doc Documentation improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels May 7, 2024
@er-eis er-eis requested review from vyasr and bdice May 9, 2024 03:44
@vyasr
Copy link
Contributor

vyasr commented May 17, 2024

/ok to test

vyasr
vyasr previously requested changes May 17, 2024
View reviewed changes
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I thought I could apply the change myself, but it seems that you haven't allowed us to push to your fork. Could you please apply the suggestion? Then we can merge. Thanks!

CONTRIBUTING.md Outdated Show resolved Hide resolved
@vyasr vyasr removed the improvement Improvement / enhancement to an existing function label May 17, 2024
@er-eis er-eis requested a review from vyasr May 19, 2024 13:57
@vyasr
Copy link
Contributor

vyasr commented May 20, 2024

/ok to test

@vyasr
Copy link
Contributor

vyasr commented May 20, 2024

/merge

@galipremsagar
Copy link
Contributor

@er-eis Could you please update your branch with the latest changes from branch-24.06?

@vyasr
Copy link
Contributor

vyasr commented May 21, 2024 •
edited
Loading

For context, CI is failing due to upstream issues and updating should fix it.

As an aside, then next time you make a PR I recommend that you check the box allowing maintainers to edit. That way we'll be able to fix these kinds of small issues before merging so that you don't have to. See this document on how that works.

@galipremsagar
Copy link
Contributor

/okay to test

@galipremsagar galipremsagar added the 5 - Ready to Merge Testing and reviews complete, ready to merge label May 21, 2024
@galipremsagar galipremsagar dismissed vyasr’s stale review May 21, 2024 01:26

Vyas request was addressed, dismissing to unblock merge

@galipremsagar
Copy link
Contributor

/merge

@rapids-bot rapids-bot bot merged commit 70922d0 into rapidsai:branch-24.06 May 21, 2024
69 checks passed
@er-eis er-eis deleted the er-eis/circular-import-contributing-md-change branch May 21, 2024 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@galipremsagar galipremsagar galipremsagar approved these changes

@bdice bdice Awaiting requested review from bdice

@vyasr vyasr Awaiting requested review from vyasr

Assignees
No one assigned
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge doc Documentation non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] pylibcudf strings circular import error
5 participants
@er-eis @vyasr @galipremsagar @bdice @mroeschke