Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enabled Holiday types in cudf.pandas #15664

Merged
merged 8 commits into from
May 9, 2024
Merged

Enabled Holiday types in cudf.pandas #15664

merged 8 commits into from
May 9, 2024

Conversation

galipremsagar
Copy link
Contributor

@galipremsagar galipremsagar commented May 6, 2024 •
edited
Loading

Description

Fixes: #15663

This PR enables Holiday types in cudf.pandas by also adding a utility to create a composite meta class.

Forks out of #14534

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@galipremsagar galipremsagar added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change cudf.pandas Issues specific to cudf.pandas labels May 6, 2024
@galipremsagar galipremsagar self-assigned this May 6, 2024
@galipremsagar galipremsagar requested a review from a team as a code owner May 6, 2024 16:49
@galipremsagar galipremsagar requested review from vyasr and bdice May 6, 2024 16:49
@github-actions github-actions bot added the Python Affects Python cuDF API. label May 6, 2024
@galipremsagar galipremsagar requested a review from mroeschke May 6, 2024 19:56
mroeschke
mroeschke reviewed May 6, 2024
View reviewed changes
Copy link
Contributor

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need any tests for this in python/cudf/cudf_pandas_tests/test_cudf_pandas.py?

@galipremsagar
Copy link
Contributor Author

Do we need any tests for this in python/cudf/cudf_pandas_tests/test_cudf_pandas.py?

Done 👍

@galipremsagar galipremsagar requested a review from mroeschke May 8, 2024 19:56
@galipremsagar galipremsagar added cudf.pandas Issues specific to cudf.pandas and removed cudf.pandas Issues specific to cudf.pandas labels May 8, 2024
@galipremsagar galipremsagar added the 5 - Ready to Merge Testing and reviews complete, ready to merge label May 8, 2024
@galipremsagar
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit c576e97 into rapidsai:branch-24.06 May 9, 2024
71 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

@vyasr vyasr Awaiting requested review from vyasr vyasr is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@bdice bdice Awaiting requested review from bdice bdice is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees

@galipremsagar galipremsagar

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge cudf.pandas Issues specific to cudf.pandas improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEA] Enable pandas Holidays in cudf.pandas
2 participants
@galipremsagar @mroeschke