New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] Enable pandas Holidays in `cudf.pandas` #15663

Closed

galipremsagar opened this issue May 6, 2024 · 0 comments · Fixed by #15664

Assignees

Labels

cudf.pandas feature request

Milestone

cudf.pandas API c...

Contributor

galipremsagar commented May 6, 2024

Is your feature request related to a problem? Please describe.
Pandas has Holidays class and it's child classes: https://github.com/pandas-dev/pandas/blob/ea7bcd14c8071e37656066cd3ed92312596892d8/pandas/tseries/holiday.py#L148, we should enable these in cudf.pandas

The text was updated successfully, but these errors were encountered:

galipremsagar added feature request cudf.pandas labels

galipremsagar added this to the cudf.pandas API coverage milestone

galipremsagar self-assigned this

galipremsagar mentioned this issue

Enabled Holiday types in cudf.pandas #15664

Merged

3 tasks

rapids-bot bot closed this as completed in #15664

rapids-bot bot pushed a commit that referenced this issue


          Enabled Holiday types in cudf.pandas (#15664)

c576e97

Fixes: #15663 

This PR enables `Holiday` types in `cudf.pandas` by also adding a utility to create a composite meta class.

Authors:
  - GALI PREM SAGAR (https://github.com/galipremsagar)

Approvers:
  - Matthew Roeschke (https://github.com/mroeschke)

URL: #15664

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment