-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use same .clang-format in cuDF JNI #15557
Use same .clang-format in cuDF JNI #15557
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have CI style check for the java folder?
The changes in this PR were enforced by pre-commit, so I’d say yes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @bdice!
JNI compilation errors are due to the reordering exposing cases where files did not IWYU. e.g.
This file uses libcudf AST types without a corresponding include. |
/merge |
Description
Closes #15546.
Currently cuDF JNI uses its own
.clang-format
settings. These settings organize includes differently than the rest of the cuDF C++ codebase, so we would like to align them.This PR removes the JNI's custom
.clang-format
and instead uses the same settings as the rest of cuDF.Checklist