Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] cuDF JNI should use the same .clang-format as the rest of cuDF #15546

Closed
harrism opened this issue Apr 16, 2024 · 2 comments · Fixed by #15557
Closed

[BUG] cuDF JNI should use the same .clang-format as the rest of cuDF #15546

harrism opened this issue Apr 16, 2024 · 2 comments · Fixed by #15557
Labels
bug Something isn't working Java Affects Java cuDF API. libcudf Affects libcudf (C++/CUDA) code.

Comments

@harrism
Copy link
Member

harrism commented Apr 16, 2024

Describe the bug
libcudf JNI has its own .clang-format file with different rules. It should not. For example, headers are ordered in the OPPOSITE order in JNI files from the order in the rest of libcudf.
@harrism harrism added bug Something isn't working libcudf Affects libcudf (C++/CUDA) code. Java Affects Java cuDF API. labels Apr 16, 2024
@bdice bdice mentioned this issue Apr 17, 2024
Merged
3 tasks
@bdice
Copy link
Contributor

bdice commented Apr 17, 2024

I opened #15557 to address this.

@ttnghia
Copy link
Contributor

ttnghia commented Apr 17, 2024

I indeed wanted to address this for a long time. Thanks for raising it up.

rapids-bot bot pushed a commit that referenced this issue Apr 18, 2024
@bdice
Use same .clang-format in cuDF JNI (#15557)
ae9e552 
Closes #15546.

Currently cuDF JNI uses its own `.clang-format` settings. These settings organize includes differently than the rest of the cuDF C++ codebase, so we would like to align them.

This PR removes the JNI's custom `.clang-format` and instead uses the same settings as the rest of cuDF.

Authors:
  - Bradley Dice (https://github.com/bdice)

Approvers:
  - Nghia Truong (https://github.com/ttnghia)
  - Mark Harris (https://github.com/harrism)

URL: #15557
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working Java Affects Java cuDF API. libcudf Affects libcudf (C++/CUDA) code.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use same .clang-format in cuDF JNI bdice/cudf
3 participants
@harrism @bdice @ttnghia