Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid .ordered and .categories from being settable in CategoricalColumn and CategoricalDtype #15475

Merged
merged 5 commits into from
Apr 9, 2024
Merged

Avoid .ordered and .categories from being settable in CategoricalColumn and CategoricalDtype #15475

merged 5 commits into from
Apr 9, 2024

Conversation

mroeschke
Copy link
Contributor

Description

A rehash of #14979

The CategoricalDtype.ordered behavior matches pandas.CategoricalDtype.ordered behavior.

Also combines as_ordered and as_unordred into 1 method, and avoids to as_index casts that are already performed elsewhere

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@mroeschke mroeschke added Python Affects Python cuDF API. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Apr 5, 2024
@mroeschke mroeschke requested a review from a team as a code owner April 5, 2024 21:38
@mroeschke mroeschke mentioned this pull request Apr 5, 2024
Closed
3 tasks
@galipremsagar
Copy link
Contributor

/merge

@rapids-bot rapids-bot bot merged commit 54eff4e into rapidsai:branch-24.06 Apr 9, 2024
75 checks passed
@mroeschke mroeschke deleted the ref/categorical_column branch April 9, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@galipremsagar galipremsagar galipremsagar approved these changes

@wence- wence- Awaiting requested review from wence- wence- is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@brandon-b-miller brandon-b-miller Awaiting requested review from brandon-b-miller brandon-b-miller is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees
No one assigned
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mroeschke @galipremsagar