Refactor CategoricalIndex.__init__, make .ordered and .categories properties from the CategoricalDtype #14979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
added
Python
bdice
reviewed
Feb 6, 2024
| if out_col.ordered: | ||
| out_col = column.build_categorical_column( | ||
| def as_ordered(self, ordered: bool): | ||
| if self.dtype.ordered != ordered: |
There was a problem hiding this comment.
I'd rather flip the if/else and structure this as an early exit.
If no work is needed (self.dtype.ordered == ordered), return self immediately.
Otherwise return the longer result of build_categorical_column.
| @@ -846,3 +846,8 @@ def test_empty_series_category_cast(ordered): | |||
|
|
|||
| assert_eq(expected, actual) | |||
| assert_eq(expected.dtype.ordered, actual.dtype.ordered) | |||
|
|
|||
|
|
|||
| def test_categoricaldtype_ordered_not_settable(): | |||
There was a problem hiding this comment.
Suggested change
| def test_categoricaldtype_ordered_not_settable(): | |
| def test_categorical_dtype_ordered_not_settable(): |
I think this change can wait until after GTC. Once |
Merged
3 tasks
|
Closing in favor of #15475 |
rapids-bot bot
pushed a commit
that referenced
this pull request
Apr 9, 2024
…mn and CategoricalDtype (#15475) A rehash of #14979 The `CategoricalDtype.ordered` behavior matches `pandas.CategoricalDtype.ordered` behavior. Also combines `as_ordered` and `as_unordred` into 1 method, and avoids to `as_index` casts that are already performed elsewhere Authors: - Matthew Roeschke (https://github.com/mroeschke) Approvers: - GALI PREM SAGAR (https://github.com/galipremsagar) URL: #15475
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In pandas,
.orderedand.categoriesare defined on theCategoricalDtypeand are not settable. Additionally, ensuring that they are only defined on the dtype and not also on the column so they don't go out-of-syncChecklist