-
Notifications
You must be signed in to change notification settings - Fork 919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for pylibcudf
binaryops
#15470
Merged
rapids-bot
merged 27 commits into
rapidsai:branch-24.08
from
brandon-b-miller:pylibcudf-binops-tests
Jul 19, 2024
Merged
Changes from 17 commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
1b482bf
patch changes from original PR
brandon-b-miller 0a46a0f
first halfway decent testing strategy
brandon-b-miller f5f33e6
refactor out a lot of repeated code
brandon-b-miller 61ab85b
cleanup
brandon-b-miller ba03539
add some more tests
brandon-b-miller 4911f33
start to work nulls in
brandon-b-miller 9eba971
merge latest/resolve conflicts
brandon-b-miller 562c765
start to refactor, pass add, almost sub
brandon-b-miller e533469
simpler approach
brandon-b-miller b81e017
Merge branch 'branch-24.08' into pylibcudf-binops-tests
brandon-b-miller e5f34e7
merge latest / resolve conflicts
brandon-b-miller 322a7de
address reviews
brandon-b-miller ecbb895
refactor again
brandon-b-miller 076b83d
address reviews, add tests
brandon-b-miller e06d5cd
fix a few ops
brandon-b-miller 473845f
few more fixes
brandon-b-miller 6e0c816
address more reviews
brandon-b-miller f0a62a9
Merge branch 'branch-24.08' into pylibcudf-binops-tests
brandon-b-miller 77c709f
fix cpp test
brandon-b-miller 4e653d6
fix atan2
brandon-b-miller 6968f95
update assert_column_eq to handle nans
brandon-b-miller cc8afe9
only check nans for floating
brandon-b-miller 12a748b
Merge branch 'branch-24.08' into pylibcudf-binops-tests
brandon-b-miller 8c44149
address reviews
brandon-b-miller 959e9a7
refactor again
brandon-b-miller 367dfe9
merge /resolve
brandon-b-miller 849e586
adjust docstring
brandon-b-miller File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See also #16239. That PR exposes reflection for casting.