-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose reflection to check if casting between two types is supported #16239
Expose reflection to check if casting between two types is supported #16239
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implementation looks good. Having pylibcudf tests would be helpful.
edit: Sorry, this is draft. Maybe I reviewed too early.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving C++ changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The C++ portion of this was straightforward enough for me to grasp.
I'm not familiar enough with the Python bit, but from a cursory look, the changes seem to track. Thank you for adding tests for this.
/merge |
Description
In cudf-polars we need to check if a cast between two datatypes is supported (and fallback, or generate different code if not).
Let's ask libcudf to be the source of truth for when a cast is supported.
Checklist