Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix base_normalator::integer_sizeof_fn integer dispatch #15457

Merged
merged 1 commit into from
Apr 4, 2024
Merged

Fix base_normalator::integer_sizeof_fn integer dispatch #15457

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions cpp/include/cudf/detail/normalizing_iterator.cuh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2023, NVIDIA CORPORATION.
* Copyright (c) 2023-2024, NVIDIA CORPORATION.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand Down Expand Up @@ -204,17 +204,17 @@ struct alignas(16) base_normalator {

private:
struct integer_sizeof_fn {
template <typename T, CUDF_ENABLE_IF(not cudf::is_fixed_width<T>())>
CUDF_HOST_DEVICE constexpr std::size_t operator()() const
template <typename T, CUDF_ENABLE_IF(not cudf::is_integral_not_bool<T>())>
CUDF_HOST_DEVICE std::size_t operator()() const
{
#ifndef __CUDA_ARCH__
CUDF_FAIL("only integral types are supported");
#else
CUDF_UNREACHABLE("only integral types are supported");
#endif
}
template <typename T, CUDF_ENABLE_IF(cudf::is_fixed_width<T>())>
CUDF_HOST_DEVICE constexpr std::size_t operator()() const noexcept
template <typename T, CUDF_ENABLE_IF(cudf::is_integral_not_bool<T>())>
CUDF_HOST_DEVICE std::size_t operator()() const noexcept
{
return sizeof(T);
}
Expand Down
Loading