Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix base_normalator::integer_sizeof_fn integer dispatch #15457

Merged
merged 1 commit into from
Apr 4, 2024
Merged

Fix base_normalator::integer_sizeof_fn integer dispatch #15457

merged 1 commit into from
Apr 4, 2024

Conversation

davidwendt
Copy link
Contributor

Description

Fixes the cudf::detail::base_normalator::integer_sizeof_fn dispatch function to support only integers. Also remove the constexpr since the non-integer path can throw an exception.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added bug Something isn't working 2 - In Progress Currently a work in progress libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change labels Apr 3, 2024
@davidwendt davidwendt self-assigned this Apr 3, 2024
@davidwendt davidwendt added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels Apr 3, 2024
@davidwendt davidwendt marked this pull request as ready for review April 3, 2024 17:42
@davidwendt davidwendt requested a review from a team as a code owner April 3, 2024 17:42
@davidwendt
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 43994fa into rapidsai:branch-24.06 Apr 4, 2024
74 checks passed
@davidwendt davidwendt deleted the fix-integer-sizeof-fn branch April 4, 2024 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vuule vuule vuule approved these changes

@karthikeyann karthikeyann karthikeyann approved these changes

@bdice bdice bdice approved these changes

@mhaseeb123 mhaseeb123 Awaiting requested review from mhaseeb123 mhaseeb123 is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees

@davidwendt davidwendt

Labels
3 - Ready for Review Ready for review by team bug Something isn't working libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@davidwendt @bdice @karthikeyann @vuule