Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow consumers of static builds to find nanoarrow #15456

Merged
merged 4 commits into from
Apr 4, 2024
Merged

Allow consumers of static builds to find nanoarrow #15456

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
45f18f5
Allow consumers of static builds to find nanoarrow
robertmaynard Apr 3, 2024
f5dc004
Fully update patch
vyasr Apr 3, 2024
7c22c7a
Strip trailing whitespace
vyasr Apr 3, 2024
c5d535d
typo
vyasr Apr 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions cpp/cmake/thirdparty/get_nanoarrow.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ function(find_and_configure_nanoarrow)
OPTIONS "BUILD_SHARED_LIBS OFF" "NANOARROW_NAMESPACE cudf"
)
set_target_properties(nanoarrow PROPERTIES POSITION_INDEPENDENT_CODE ON)
rapids_export_find_package_root(BUILD nanoarrow "${nanoarrow_BINARY_DIR}" EXPORT_SET cudf-exports)
endfunction()

find_and_configure_nanoarrow(
Expand Down
2 changes: 1 addition & 1 deletion cpp/cmake/thirdparty/patches/nanoarrow_cmake.diff
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ index 8714c70..1feec13 100644

- install(TARGETS nanoarrow DESTINATION lib)
+ install(TARGETS nanoarrow
+ DESTINATION lib
+ DESTINATION "${CMAKE_INSTALL_LIBDIR}"
+ EXPORT nanoarrow-exports)
install(DIRECTORY src/
DESTINATION include
robertmaynard marked this conversation as resolved.
Show resolved Hide resolved
Expand Down
Loading