Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow consumers of static builds to find nanoarrow #15456

Conversation

robertmaynard
Copy link
Contributor

Description

Allows consumers like spark-rapids to bring in libcudf static builds from the install and build trees.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@robertmaynard robertmaynard added bug Something isn't working 3 - Ready for Review Ready for review by team non-breaking Non-breaking change labels Apr 3, 2024
@robertmaynard robertmaynard requested a review from a team as a code owner April 3, 2024 17:05
@github-actions github-actions bot added libcudf Affects libcudf (C++/CUDA) code. CMake CMake build issue labels Apr 3, 2024
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

@vyasr
Copy link
Contributor

vyasr commented Apr 3, 2024

@robertmaynard feel free to merge assuming my changes look OK to you.

@vyasr
Copy link
Contributor

vyasr commented Apr 4, 2024

Given that this is blocking Spark builds, I'm going to go ahead and merge this. If there are further changes needed for Spark or clean up that we'd like to see, I'd say we can do that in a follow-up.

@vyasr
Copy link
Contributor

vyasr commented Apr 4, 2024

/merge

@rapids-bot rapids-bot bot merged commit c0f84bf into rapidsai:branch-24.06 Apr 4, 2024
74 checks passed
@robertmaynard robertmaynard deleted the bug/allow_static_builds_with_nanoarrow branch June 17, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team bug Something isn't working CMake CMake build issue libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Importing statically configured libcudf fails with missing nanoarrow dependency
4 participants