Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated strings offsets_begin #15454

Merged
merged 2 commits into from
Apr 8, 2024

Conversation

davidwendt
Copy link
Contributor

Description

Removes the deprecated cudf::strings_column_view::offsets_begin() and cudf::strings_column_view::offsets_end() member functions. These are replaced with offsetalator wrapper calls instead.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added 2 - In Progress Currently a work in progress libcudf Affects libcudf (C++/CUDA) code. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Apr 3, 2024
@davidwendt davidwendt self-assigned this Apr 3, 2024
@davidwendt davidwendt added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels Apr 3, 2024
@davidwendt davidwendt marked this pull request as ready for review April 4, 2024 21:06
@davidwendt davidwendt requested a review from a team as a code owner April 4, 2024 21:06
@davidwendt davidwendt requested review from mythrocks and shrshi April 4, 2024 21:06
@davidwendt davidwendt added breaking Breaking change and removed non-breaking Non-breaking change labels Apr 8, 2024
@davidwendt
Copy link
Contributor Author

Even though this is removing a deprecated function, changing this to breaking since consumers would be affected.

@davidwendt
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 7750afc into rapidsai:branch-24.06 Apr 8, 2024
74 checks passed
@davidwendt davidwendt deleted the remove-offsets-begin branch April 8, 2024 16:54
@vyasr
Copy link
Contributor

vyasr commented Apr 9, 2024

Even though this is removing a deprecated function, changing this to breaking since consumers would be affected.

IMO every PR removing deprecated functions should be marked as breaking since that's when the functionality actually becomes unavailable. Conversely PRs that deprecate functionality typically shouldn't be marked as breaking since calling code will continue to work. Of course, it's a blurry line since code compiled with e.g. -Wno-error=deprecated-declarations will fail even on the deprecation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team breaking Breaking change improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants