Skip to content

Commit

Permalink
Remove deprecated strings offsets_begin (#15454)
Browse files Browse the repository at this point in the history
Removes the deprecated `cudf::strings_column_view::offsets_begin()` and `cudf::strings_column_view::offsets_end()` member functions. These are replaced with offsetalator wrapper calls instead.

Authors:
  - David Wendt (https://github.com/davidwendt)

Approvers:
  - Bradley Dice (https://github.com/bdice)
  - Shruti Shivakumar (https://github.com/shrshi)

URL: #15454
  • Loading branch information
davidwendt authored Apr 8, 2024
1 parent 3896222 commit 7750afc
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 32 deletions.
22 changes: 0 additions & 22 deletions cpp/include/cudf/strings/strings_column_view.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -85,28 +85,6 @@ class strings_column_view : private column_view {
*/
[[nodiscard]] column_view offsets() const;

/**
* @brief Return an iterator for the offsets child column.
*
* @deprecated Since 24.04
*
* This automatically applies the offset of the parent.
*
* @return Iterator pointing to the first offset value.
*/
[[deprecated]] offset_iterator offsets_begin() const;

/**
* @brief Return an end iterator for the offsets child column.
*
* @deprecated Since 24.04
*
* This automatically applies the offset of the parent.
*
* @return Iterator pointing 1 past the last offset value.
*/
[[deprecated]] offset_iterator offsets_end() const;

/**
* @brief Returns the number of bytes in the chars child column.
*
Expand Down
10 changes: 0 additions & 10 deletions cpp/src/strings/strings_column_view.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -35,16 +35,6 @@ column_view strings_column_view::offsets() const
return child(offsets_column_index);
}

strings_column_view::offset_iterator strings_column_view::offsets_begin() const
{
return offsets().begin<int32_t>() + offset();
}

strings_column_view::offset_iterator strings_column_view::offsets_end() const
{
return offsets().begin<int32_t>() + offset() + size() + 1;
}

int64_t strings_column_view::chars_size(rmm::cuda_stream_view stream) const noexcept
{
if (size() == 0) { return 0L; }
Expand Down

0 comments on commit 7750afc

Please sign in to comment.