-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Parquet encoding statistics to column chunk metadata #15452
Merged
Merged
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
e88251a
add thrift support for page encoding stats
etseidl 702a0ef
set encoding_stats
etseidl 93c9aff
Merge branch 'rapidsai:branch-24.06' into enc_stats
etseidl 52f0df6
add test of encoding stats
etseidl 7a0ff87
Merge branch 'enc_stats' of github.com:etseidl/cudf into enc_stats
etseidl 9d7cef8
add docstring
etseidl 7012de1
fix includes
etseidl b5fcf24
Merge remote-tracking branch 'origin/branch-24.06' into enc_stats
etseidl 48542c1
Merge branch 'branch-24.06' into enc_stats
etseidl 581597a
Merge branch 'branch-24.06' into enc_stats
ttnghia 843616d
Merge branch 'branch-24.06' into enc_stats
etseidl 49969e3
Merge branch 'rapidsai:branch-24.06' into enc_stats
etseidl d6ca22b
Merge branch 'branch-24.06' into enc_stats
etseidl 3ff987d
Merge branch 'branch-24.06' into enc_stats
etseidl b989e9d
Merge remote-tracking branch 'origin/branch-24.06' into enc_stats
etseidl ed57bbf
Merge branch 'branch-24.06' into enc_stats
etseidl 7852a84
Merge remote-tracking branch 'origin/branch-24.06' into enc_stats
etseidl a3eb567
Merge remote-tracking branch 'origin/branch-24.06' into enc_stats
etseidl 8389aef
Merge branch 'branch-24.06' into enc_stats
ttnghia ac5a0ea
Merge branch 'branch-24.06' into enc_stats
ttnghia File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the empty line above 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry, but clang-format insists on that line being there 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's weird. Definitely clang-format bug 😓
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah. Maybe a special group for header with the same root as the compilation unit 🤷
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@harrism Would you mind looking into this please?