Add Parquet encoding statistics to column chunk metadata #15452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ttnghia
reviewed
Apr 6, 2024
| @@ -16,6 +16,9 @@ | |||
|
|
|||
| #include "compact_protocol_reader.hpp" | |||
|
|
|||
| #include "parquet.hpp" | |||
There was a problem hiding this comment.
Please remove the empty line above 😄
There was a problem hiding this comment.
sorry, but clang-format insists on that line being there 😅
There was a problem hiding this comment.
It's weird. Definitely clang-format bug 😓
There was a problem hiding this comment.
Yeah. Maybe a special group for header with the same root as the compilation unit 🤷
There was a problem hiding this comment.
@harrism Would you mind looking into this please?
ttnghia
reviewed
Apr 6, 2024
ttnghia
approved these changes
Apr 6, 2024
ttnghia
added
feature request
|
/ok to test |
|
/ok to test |
mhaseeb123
approved these changes
Apr 10, 2024
|
Thanks for the effort Ed, looks good to me! |
|
/ok to test |
|
/ok to test |
|
/merge |
|
/ok to test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #15313
Checklist