update dev env link #15401
Closed
update dev env link #15401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge pull request rapidsai#5690 from ajschmidt8/phase2 [skip ci] Update master references for main branch
[RELEASE] Re-release v0.15 cudf [skip-ci]
[RELEASE] cudf v0.17
[RELEASE] cudf v0.18
[RELEASE] Release v0.18.1 cudf
[RELEASE] v0.18.2 `cudf` release [skip-ci]
[RELEASE] v0.19.1 cudf
[RELEASE] v0.19.2 cudf [skip-ci]
[HOTFIX] v23.10.02
[HOTFIX] `v23.12.01`
[HOTFIX] v24.02.01
[RELEASE] v24.02.02
|
Thanks for the contribution @raybellwaves! I agree that this would be a good change. We do our development off of release-versioned branches, so this should be based on branch-24.06 instead of main (confusing, I know). Could you please rebase your changes and push? Then we can get CI running here. |
|
Not a problem, thanks! |
rapids-bot bot
pushed a commit
that referenced
this pull request
Apr 13, 2024
clean commit of #15401 Authors: - Ray Bell (https://github.com/raybellwaves) - Bradley Dice (https://github.com/bdice) Approvers: - Nghia Truong (https://github.com/ttnghia) - Bradley Dice (https://github.com/bdice) URL: #15467
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Going through the contributing document (https://github.com/rapidsai/cudf/blob/branch-24.06/CONTRIBUTING.md#create-the-build-environment) and thought i'd update the env to point to the cuda-120 file as I assume it's the most recent version and Is used more often. That said, i'm guessing the cuda-118 file exists to build against different cuda versions and it may have been chosen intensionally.
Apologies for small PR's i'm creating. I understand they take time to review. I'm not expecting and fast reviews and don't mind if they are closed for being out of scope. I just see small ways to increase the new user experience.