Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RELEASE] cudf v23.12 #14468

Merged
merged 154 commits into from
Dec 6, 2023
Merged

[RELEASE] cudf v23.12 #14468

merged 154 commits into from
Dec 6, 2023

Conversation

raydouglass
Copy link
Member

❄️ Code freeze for branch-23.12 and v23.12 release

What does this mean?

Only critical/hotfix level issues should be merged into branch-23.12 until release (merging of this PR).

What is the purpose of this PR?

  • Update documentation
  • Allow testing for the new release
  • Enable a means to merge branch-23.12 into main for the release

raydouglass and others added 30 commits September 22, 2023 10:19
@raydouglass
v23.12 Updates [skip ci]
f42231f
@GPUtester
Merge pull request #14174 from rapidsai/branch-23.10
e591d00 
Forward-merge branch-23.10 to branch-23.12
@GPUtester
Merge pull request #14176 from rapidsai/branch-23.10
e889bae 
Forward-merge branch-23.10 to branch-23.12
@GPUtester
Merge pull request #14177 from rapidsai/branch-23.10
6ebae76 
Forward-merge branch-23.10 to branch-23.12
@GPUtester
Merge pull request #14178 from rapidsai/branch-23.10
6fea450 
Forward-merge branch-23.10 to branch-23.12
@GPUtester
Merge pull request #14179 from rapidsai/branch-23.10
007f43c 
Forward-merge branch-23.10 to branch-23.12
@GPUtester
Merge pull request #14180 from rapidsai/branch-23.10
b438d56 
Forward-merge branch-23.10 to branch-23.12
@GPUtester
Merge pull request #14181 from rapidsai/branch-23.10
e1a0ea3 
Forward-merge branch-23.10 to branch-23.12
@GPUtester
Merge pull request #14182 from rapidsai/branch-23.10
294b0b3 
Forward-merge branch-23.10 to branch-23.12
@GPUtester
Merge pull request #14184 from rapidsai/branch-23.10
5c8a4a0 
Forward-merge branch-23.10 to branch-23.12
@GPUtester
Merge pull request #14185 from rapidsai/branch-23.10
a5e30de 
Forward-merge branch-23.10 to branch-23.12
@GPUtester
Merge pull request #14186 from rapidsai/branch-23.10
75b08ee 
Forward-merge branch-23.10 to branch-23.12
@GPUtester
Merge pull request #14188 from rapidsai/branch-23.10
5f5b55c 
Forward-merge branch-23.10 to branch-23.12
@GPUtester
Merge pull request #14189 from rapidsai/branch-23.10
77d45e3 
Forward-merge branch-23.10 to branch-23.12
@GPUtester
Merge pull request #14194 from rapidsai/branch-23.10
4137a97 
Forward-merge branch-23.10 to branch-23.12
@GPUtester
Merge pull request #14199 from rapidsai/branch-23.10
77f05d4 
Forward-merge branch-23.10 to branch-23.12
@GPUtester
Merge pull request #14203 from rapidsai/branch-23.10
30093c3 
Forward-merge branch-23.10 to branch-23.12
@GPUtester
Merge pull request #14204 from rapidsai/branch-23.10
62a49a2 
Forward-merge branch-23.10 to branch-23.12
@GPUtester
Merge pull request #14207 from rapidsai/branch-23.10
b763b8b 
Forward-merge branch-23.10 to branch-23.12
@wence-
Marginally reduce memory footprint of joins (#14197)
cdc03a7 
If we drop the gather maps as soon as we are done with them, we have a little more headroom for joins that are close to hitting the device memory limit.

Authors:
  - Lawrence Mitchell (https://github.com/wence-)

Approvers:
  - GALI PREM SAGAR (https://github.com/galipremsagar)
  - Bradley Dice (https://github.com/bdice)
  - Matthew Roeschke (https://github.com/mroeschke)

URL: #14197
@GPUtester
Merge pull request #14211 from rapidsai/branch-23.10
b838e64 
Forward-merge branch-23.10 to branch-23.12
@GPUtester
Merge pull request #14213 from rapidsai/branch-23.10
90bedcb 
Forward-merge branch-23.10 to branch-23.12
@GPUtester
Merge pull request #14220 from rapidsai/branch-23.10
8342caa 
Forward-merge branch-23.10 to branch-23.12
@GPUtester
Merge pull request #14221 from rapidsai/branch-23.10
c6fea7d 
Forward-merge branch-23.10 to branch-23.12
@GPUtester
Merge pull request #14222 from rapidsai/branch-23.10
d01b69e 
Forward-merge branch-23.10 to branch-23.12
@GPUtester
Merge pull request #14223 from rapidsai/branch-23.10
dea0df0 
Forward-merge branch-23.10 to branch-23.12
@Blonck
Add bytes_per_second to distinct_count of stream_compaction nvbench. (
23d24d4 
#14172)

This patch relates to #13735.

Benchmark:  [benchmark_distinct_count.txt](https://github.com/rapidsai/cudf/files/12700496/benchmark_distinct_count.txt)

Authors:
  - Martin Marenz (https://github.com/Blonck)
  - Mark Harris (https://github.com/harrism)

Approvers:
  - David Wendt (https://github.com/davidwendt)
  - Karthikeyan (https://github.com/karthikeyann)
  - Mark Harris (https://github.com/harrism)

URL: #14172
@galipremsagar
Merge branch-23.10 into branch-23.12
801c9cf
@raydouglass
Merge pull request #14231 from galipremsagar/branch-23.12-merge-23.10
7825790 
Forward merge `23.10` into `23.12`
@bdice
cuDF: Build CUDA 12.0 ARM conda packages. (#14112)
59b09fd 
This PR builds conda packages using CUDA 12 on ARM.

This work is targeting 23.12 and depends on rapidsai/rmm#1330.

Closes #14128.

Authors:
  - Bradley Dice (https://github.com/bdice)

Approvers:
  - Ray Douglass (https://github.com/raydouglass)

URL: #14112
divyegala and others added 7 commits November 16, 2023 21:43
@divyegala
Change nullable() to has_nulls() in cudf::detail::gather (#14363)
8e1ef05 
In #13795, we found out that `nullable()` causes severe perf degradation for the nested-type case when the input is read from file via `cudf::io::read_json`. This is because the JSON reader adds a null mask for columns that don't have NULLs. This change is a no-overhead replacement that checks the actual null count instead of checking if a null mask is present.

This PR also solves a bug in quantile/median groupby where NULLs were being [set](https://github.com/rapidsai/cudf/blob/8deb3dd7573000e7d87f18a9e2bbe39cf2932e10/cpp/src/groupby/sort/group_quantiles.cu#L73) but the null count was not updated.

Authors:
  - Divye Gala (https://github.com/divyegala)
  - Vyas Ramasubramani (https://github.com/vyasr)

Approvers:
  - Bradley Dice (https://github.com/bdice)
  - Vyas Ramasubramani (https://github.com/vyasr)
  - David Wendt (https://github.com/davidwendt)
  - Nghia Truong (https://github.com/ttnghia)

URL: #14363
@etseidl
Add decoder for DELTA_BYTE_ARRAY to Parquet reader (#14101)
bf63d10 
Part of #13501. Adds ability to decode DELTA_BYTE_ARRAY encoded pages.

Authors:
  - Ed Seidl (https://github.com/etseidl)
  - Vukasin Milovanovic (https://github.com/vuule)

Approvers:
  - Vukasin Milovanovic (https://github.com/vuule)
  - https://github.com/nvdbaranec
  - GALI PREM SAGAR (https://github.com/galipremsagar)

URL: #14101
@bdice
Enable build concurrency for nightly and merge triggers. (#14441)
ba5ec40
@tpn
Implement user_datasource_wrapper is_empty() and is_device_read_prefe…
6c2e972 
…rred(). (#14357)

These two routines are missing from the current `user_datasource_wrapper` impl.

Authors:
  - Trent Nelson (https://github.com/tpn)
  - Vukasin Milovanovic (https://github.com/vuule)

Approvers:
  - Mike Wilson (https://github.com/hyperbolic2346)
  - Vukasin Milovanovic (https://github.com/vuule)

URL: #14357
@vyasr
Fix intermediate type checking in expression parsing (#14445)
723c565 
When parsing expressions, device data references are reused if there are multiple that are identical. Equality is determined by comparing the fields of the reference, but previously the data type was omitted. For column and literal references, this is OK because the `data_index` uniquely identifies the reference. For intermediates, however, the index is not sufficient to disambiguate because an expression could reuse a given location even if the operation produces a different data type. Therefore, the data type must be part of the equality operator.

Resolves #14409

Authors:
  - Vyas Ramasubramani (https://github.com/vyasr)

Approvers:
  - David Wendt (https://github.com/davidwendt)
  - Bradley Dice (https://github.com/bdice)

URL: #14445
@bdice
Fix io reference in docs. (#14452)
3ef13d0 
cuDF CI is failing to build docs due to an ambiguous reference `io`. This PR makes that reference unambiguous.

```
/__w/cudf/cudf/docs/cudf/source/user_guide/data-types.md:139: WARNING: Multiple matches found for 'io': pandas:std:label:io, pyarrow:std:label:io, python:py:module:io [myst.iref_ambiguous]
```

I used this output to help me find the object inventory that lists this.

```bash
python -m sphinx.ext.intersphinx https://docs.rapids.ai/api/cudf/stable/objects.inv
```

I also looked at the MyST docs on external references. https://mystmd.org/guide/external-references

Authors:
  - Bradley Dice (https://github.com/bdice)

Approvers:
  - Lawrence Mitchell (https://github.com/wence-)

URL: #14452
@brandon-b-miller
Use pynvjitlink for CUDA 12+ MVC (#13650)
823d321 
Fixes #12822

This PR provides minor version compatibility in the CUDA 12.x range through `nvjitlink` via the preliminary [nvjiitlink python binding](https://github.com/gmarkall/nvjitlink). Thus far this PR merely leverages a local installation of the library and should not be merged until `nvjitlink` is hosted on `conda-forge` and cuDF's dependencies are adjusted accordingly, likely as part of this PR.

Authors:
  - https://github.com/brandon-b-miller
  - Ashwin Srinath (https://github.com/shwina)

Approvers:
  - Bradley Dice (https://github.com/bdice)
  - Ashwin Srinath (https://github.com/shwina)

URL: #13650
@raydouglass raydouglass requested review from a team as code owners November 21, 2023 21:51
@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Nov 21, 2023

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions github-actions bot added libcudf Affects libcudf (C++/CUDA) code. Python Affects Python cuDF API. CMake CMake build issue conda Java Affects Java cuDF API. labels Nov 21, 2023
galipremsagar and others added 5 commits November 28, 2023 15:13
@galipremsagar
Fix function name typo in cudf.pandas profiler (#14514)
fc8c81f 
Fixes: #14512 

This PR fixes a function name typo in `cudf.pandas` profiler.

Authors:
   - GALI PREM SAGAR (https://github.com/galipremsagar)

Approvers:
   - Bradley Dice (https://github.com/bdice)
@raydouglass
Merge pull request #14435 from rapidsai/branch-23.10
68cb1d9 
Forward merge `branch-23.10` into `branch-23.12`
@raydouglass
Pin actions/labeler to v4 [skip ci] (#14562)
0a56305 
RAPIDS repos are using the `main` branch of https://github.com/actions/labeler which recently introduced [breaking changes](https://github.com/actions/labeler/releases/tag/v5.0.0).

This PR pins to the latest v4 release of the labeler action until we can evaluate the changes required for v5.

Authors:
   - Ray Douglass (https://github.com/raydouglass)

Approvers:
   - AJ Schmidt (https://github.com/ajschmidt8)
@etseidl
fix for skip_rows on with page-spanning rows (#14557)
31aedf2 
Fixes an issue detected in Spark where string data was being corrupted due to an incorrect page size calculation.

Closes #14560 

Authors:
   - Ed Seidl (https://github.com/etseidl)

Approvers:
   - Alessandro Bellina (https://github.com/abellina)
   - Yunsong Wang (https://github.com/PointKernel)
   - Vukasin Milovanovic (https://github.com/vuule)
   - Nghia Truong (https://github.com/ttnghia)
   - Mike Wilson (https://github.com/hyperbolic2346)
@raydouglass
Update Changelog [skip ci]
8eacf8f
@raydouglass raydouglass merged commit 38bbf9e into main Dec 6, 2023
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@galipremsagar galipremsagar Awaiting requested review from galipremsagar galipremsagar is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@isVoid isVoid Awaiting requested review from isVoid isVoid is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@PointKernel PointKernel Awaiting requested review from PointKernel PointKernel is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

@divyegala divyegala Awaiting requested review from divyegala divyegala is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees
No one assigned
Labels
CMake CMake build issue Java Affects Java cuDF API. libcudf Affects libcudf (C++/CUDA) code. Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.