Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement user_datasource_wrapper is_empty() and is_device_read_preferred(). #14357

Merged
merged 4 commits into from
Nov 17, 2023
Merged

Implement user_datasource_wrapper is_empty() and is_device_read_preferred(). #14357

merged 4 commits into from
Nov 17, 2023

Conversation

tpn
Copy link
Contributor

@tpn tpn commented Nov 3, 2023

Description

These two routines are missing from the current user_datasource_wrapper impl.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@tpn tpn requested a review from a team as a code owner November 3, 2023 18:35
@tpn tpn requested review from harrism and hyperbolic2346 November 3, 2023 18:35
@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Nov 3, 2023

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Nov 3, 2023
@tpn tpn mentioned this pull request Nov 3, 2023
Closed
@vyasr
Copy link
Contributor

vyasr commented Nov 3, 2023

/ok to test

@tpn
Copy link
Contributor Author

tpn commented Nov 7, 2023

Friendly ping for another /ok to test... I think the one on Friday bombed out for unrelated reasons.

@davidwendt davidwendt added 3 - Ready for Review Ready for review by team cuIO cuIO issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Nov 7, 2023
@davidwendt
Copy link
Contributor

/ok to test

@tpn
Copy link
Contributor Author

tpn commented Nov 13, 2023

Want me to rebase this against 23.12? I think it's otherwise ready to merge, correct?

@tpn
Copy link
Contributor Author

tpn commented Nov 16, 2023

Friendly ping, any thoughts on getting this merged?

@davidwendt
Copy link
Contributor

cc @vuule

vuule
vuule approved these changes Nov 17, 2023
View reviewed changes
Copy link
Contributor

@vuule vuule left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good
Thank you for the patch!

@vuule
Copy link
Contributor

vuule commented Nov 17, 2023

/ok to test

@vuule vuule added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team labels Nov 17, 2023
@vuule
Copy link
Contributor

vuule commented Nov 17, 2023

/merge

@rapids-bot rapids-bot bot merged commit 6c2e972 into rapidsai:branch-23.12 Nov 17, 2023
64 of 65 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vuule vuule vuule approved these changes

@hyperbolic2346 hyperbolic2346 hyperbolic2346 approved these changes

@harrism harrism Awaiting requested review from harrism harrism is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees
No one assigned
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge cuIO cuIO issue improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tpn @vyasr @davidwendt @vuule @hyperbolic2346