Use logical types in Parquet reader #15365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mythrocks
added
improvement
mythrocks
reviewed
Mar 22, 2024
|
/ok to test |
ttnghia
approved these changes
Mar 23, 2024
vuule
reviewed
Mar 25, 2024
Comment on lines
+378
to
389
| // TODO(ets): this is leftover from the original code, but will we ever output decimal as | ||
| // anything but fixed point? | ||
| if (logical_type.has_value() and logical_type->type == LogicalType::DECIMAL) { | ||
| // if decimal but not outputting as float or decimal, then convert to no logical type | ||
| if (column_type_id != type_id::FLOAT64 and | ||
| not cudf::is_fixed_point(data_type{column_type_id})) { | ||
| return std::make_tuple(clock_rate, thrust::nullopt); | ||
| } | ||
| } | ||
|
|
||
| int8_t converted_type = converted.value_or(UNKNOWN); | ||
| if (converted_type == DECIMAL && column_type_id != type_id::FLOAT64 && | ||
| not cudf::is_fixed_point(data_type{column_type_id})) { | ||
| converted_type = UNKNOWN; // Not converting to float64 or decimal | ||
| } | ||
| return std::make_tuple(type_width, clock_rate, converted_type); | ||
| return std::make_tuple(clock_rate, std::move(logical_type)); | ||
| } |
There was a problem hiding this comment.
A note from an offline discussion: we don't understand when this logic is useful (yet?)
There was a problem hiding this comment.
Further context: it seems in the distant past what is now handled by decimal128 was converted to FLOAT64. This is no longer the case, so the above logic can (most likely) be safely removed and this entire function changed to return just clock_rate.
vuule
approved these changes
Mar 25, 2024
|
/ok to test |
|
/ok to test |
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #15224. Now use logical type exclusively in the reader rather than the deprecated converted type.
Checklist