Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] Parquet reader should use LogicalType rather than ConvertedType #15224

Closed
etseidl opened this issue Mar 4, 2024 · 0 comments · Fixed by #15365
Closed

[FEA] Parquet reader should use LogicalType rather than ConvertedType #15224

etseidl opened this issue Mar 4, 2024 · 0 comments · Fixed by #15365
Labels
cuIO cuIO issue feature request New feature or request libcudf Affects libcudf (C++/CUDA) code.

Comments

@etseidl
Copy link
Contributor

etseidl commented Mar 4, 2024

Is your feature request related to a problem? Please describe.
The current Parquet reader depends heavily on the deprecated ConvertedType enum, as well as the associated (and also deprecated) scale and precision fields in the SchemaElement struct. Also, handling of some data types (such as string to category transformations performed on BYTE_ARRAY columns) relies on magic numbers rather than flags (see here and here for examples). Further, due to the fact that the ConvertedType enum is no longer updated, the handling of certain types (e.g. nanosecond timestamps) currently examines both the converted type and the logical type, where simply using the logical type would suffice. New types added to specification, such as UUID and FLOAT16 also require use of a logical type annotation for FIXED_LEN_BYTE_ARRAY encoded data.

Describe the solution you'd like
I would like for the Parquet decoder kernels to exclusively use Parquet physical and logical type data rather than a hodgepodge of physical, converted, logical types and magic numbers. There are well defined mappings of ConvertedTypes to LogicalTypes, so older files that lack LogicalType info can still be handled.

Describe alternatives you've considered
We could make use of LogicalType info for new types only and keep the old ConvertedType logic.

Additional context
Implementing this change will require a great deal of care and testing to make sure there are no user visible changes. For instance, the introduction of LogicalType had unintended consequences due to inconsistent prior handling of UTC conversion (#14322).

@etseidl etseidl added the feature request New feature or request label Mar 4, 2024
@GregoryKimball GregoryKimball added libcudf Affects libcudf (C++/CUDA) code. cuIO cuIO issue labels Mar 6, 2024
@GregoryKimball GregoryKimball moved this to Needs owner in libcudf Mar 6, 2024
rapids-bot bot pushed a commit that referenced this issue Mar 27, 2024
Closes #15224. Now use logical type exclusively in the reader rather than the deprecated converted type.

Authors:
  - Ed Seidl (https://github.com/etseidl)
  - Vukasin Milovanovic (https://github.com/vuule)

Approvers:
  - Nghia Truong (https://github.com/ttnghia)
  - MithunR (https://github.com/mythrocks)
  - Vukasin Milovanovic (https://github.com/vuule)

URL: #15365
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cuIO cuIO issue feature request New feature or request libcudf Affects libcudf (C++/CUDA) code.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants