Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily disable docs errors. #15265

Merged
merged 4 commits into from
Mar 11, 2024

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Mar 10, 2024

Description

Currently there are some network issues affecting docs builds. To prevent this from causing complete CI blockage, we can temporarily allow errors in the docs build. This will allow us to monitor the network status and re-enable the docs builds when the network issues are resolved.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@github-actions github-actions bot added the ci label Mar 10, 2024
@bdice bdice added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change doc Documentation and removed improvement Improvement / enhancement to an existing function labels Mar 10, 2024
@bdice
Copy link
Contributor Author

bdice commented Mar 10, 2024

This depends on #15261 for CI to pass. I am rerunning CI with #15261 merged into this to ensure that CI passes.

We have two options for a merge plan:

  1. Merge this PR directly and close Ensure astype("interval") only matches the "interval" string #15261 since the changes will be upstreamed
  2. For a cleaner history, we can admin-merge Ensure astype("interval") only matches the "interval" string #15261, then rebase this PR to contain only 6ec3c00, and then admin-merge this PR to unblock CI

@github-actions github-actions bot added the Python Affects Python cuDF API. label Mar 10, 2024
@bdice bdice marked this pull request as ready for review March 10, 2024 17:06
@bdice bdice requested review from a team as code owners March 10, 2024 17:06
@bdice bdice requested review from vyasr and isVoid March 10, 2024 17:06
@AyodeAwe
Copy link
Contributor

/merge

@rapids-bot rapids-bot bot merged commit c794ce4 into rapidsai:branch-24.04 Mar 11, 2024
78 checks passed
bdice added a commit to bdice/cudf that referenced this pull request Mar 11, 2024
rapids-bot bot pushed a commit that referenced this pull request Mar 11, 2024
This reverts part of commit c794ce4. This PR can be merged after the docs.rapids.ai issues are resolved. cc: @raydouglass @AyodeAwe

PR #15265 unblocked CI for cudf by disabling errors in the docs. However, it also included the diff from #15261 so that CI would pass. This reverts the docs build changes but leaves in the changes from #15261.

Authors:
  - Bradley Dice (https://github.com/bdice)

Approvers:
  - Jake Awe (https://github.com/AyodeAwe)

URL: #15269
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Documentation non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants