Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement grouped product scan #15254

Merged
merged 6 commits into from
Mar 11, 2024
Merged

Implement grouped product scan #15254

merged 6 commits into from
Mar 11, 2024

Conversation

wence-
Copy link
Contributor

@wence- wence- commented Mar 8, 2024

Description

Although cumulative products are implemented for whole-frame scans, they were not for grouped aggregations.
Plumb through the necessary machinery to enable this. Only enabled for floating and integral types: the units make no sense for durations.

As for the whole-frame product aggregation, it is very easy to overflow the output type. For floating types this will result in +/- inf as the result. For signed integral types, behaviour is undefined on overflow.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@wence- wence- requested review from a team as code owners March 8, 2024 10:41
@github-actions github-actions bot added libcudf Affects libcudf (C++/CUDA) code. Python Affects Python cuDF API. CMake CMake build issue labels Mar 8, 2024
@wence- wence- added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Mar 8, 2024
davidwendt
davidwendt approved these changes Mar 8, 2024
View reviewed changes
Copy link
Contributor

@davidwendt davidwendt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving C++ changes

@wence-
Copy link
Contributor Author

wence- commented Mar 11, 2024

/merge

@bdice
Copy link
Contributor

bdice commented Mar 11, 2024

I'll merge the upstream so that the /merge command is triggered. (It was blocked by #15265)

@rapids-bot rapids-bot bot merged commit 241825a into rapidsai:branch-24.04 Mar 11, 2024
78 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidwendt davidwendt davidwendt approved these changes

@bdice bdice bdice approved these changes

@brandon-b-miller brandon-b-miller Awaiting requested review from brandon-b-miller brandon-b-miller is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@vuule vuule Awaiting requested review from vuule vuule is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees
No one assigned
Labels
CMake CMake build issue improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEA] Support cumprod in DataFrameGroupBy
3 participants
@wence- @bdice @davidwendt