Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate strings_column_view::offsets_begin() #15205

Merged

Conversation

davidwendt
Copy link
Contributor

Description

Deprecates the cudf::strings_column_view::offsets_begin() and cudf::strings_column_view::offsets_end() since they are hardcoded to return size_type*. There are very few places that used these functions.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added 2 - In Progress Currently a work in progress libcudf Affects libcudf (C++/CUDA) code. strings strings issues (C++ and Python) improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Mar 1, 2024
@davidwendt davidwendt self-assigned this Mar 1, 2024
@davidwendt
Copy link
Contributor Author

The calls in replace.cu and multi.cu have already been removed in #14824
I wanted to get this merged sooner than later before 24.04 finishes.

@davidwendt davidwendt added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels Mar 4, 2024
@davidwendt davidwendt marked this pull request as ready for review March 4, 2024 19:00
@davidwendt davidwendt requested a review from a team as a code owner March 4, 2024 19:00
@davidwendt davidwendt requested review from harrism and nvdbaranec March 4, 2024 19:00
@davidwendt
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit ab20f47 into rapidsai:branch-24.04 Mar 6, 2024
74 checks passed
@davidwendt davidwendt deleted the deprecate-offsets-begin branch March 6, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change strings strings issues (C++ and Python)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants