Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use offsetalator in cudf::strings::replace functions #14824

Merged
merged 44 commits into from
Apr 3, 2024
Merged

Use offsetalator in cudf::strings::replace functions #14824

merged 44 commits into from
Apr 3, 2024

Conversation

davidwendt
Copy link
Contributor

Description

Adds offsetalator in place of hardcoded offset size_type arrays to the strings replace functions.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added 2 - In Progress Currently a work in progress libcudf Affects libcudf (C++/CUDA) code. strings strings issues (C++ and Python) improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jan 22, 2024
@davidwendt davidwendt self-assigned this Jan 22, 2024
@GregoryKimball GregoryKimball mentioned this pull request Jan 23, 2024
Closed
@davidwendt davidwendt changed the title Use offsetalator in strings:replace functions Use offsetalator in cudf::strings::replace functions Jan 26, 2024
@davidwendt davidwendt added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels Feb 2, 2024
@github-actions github-actions bot added the CMake CMake build issue label Feb 9, 2024
@davidwendt davidwendt mentioned this pull request Feb 14, 2024
Merged
3 tasks
@davidwendt davidwendt marked this pull request as ready for review February 29, 2024 18:39
@davidwendt davidwendt requested a review from a team as a code owner February 29, 2024 18:39
@davidwendt davidwendt mentioned this pull request Mar 1, 2024
Merged
3 tasks
bdice
bdice reviewed Mar 14, 2024
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small comments but nothing blocking. Happy to approve once you take a look.

cpp/src/strings/replace/multi.cu Outdated Show resolved Hide resolved
cpp/src/strings/replace/replace.cu Outdated Show resolved Hide resolved
cpp/src/strings/replace/replace.cu Outdated Show resolved Hide resolved
cpp/src/strings/replace/replace.cu Outdated Show resolved Hide resolved
cpp/src/strings/replace/replace.cu Outdated Show resolved Hide resolved
bdice
bdice approved these changes Mar 15, 2024
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidwendt davidwendt changed the base branch from branch-24.04 to branch-24.06 March 18, 2024 13:42
@vyasr
Copy link
Contributor

vyasr commented Apr 2, 2024

Sorry I missed this earlier. Approved.

@davidwendt
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 082f6c9 into rapidsai:branch-24.06 Apr 3, 2024
75 checks passed
@davidwendt davidwendt deleted the replace-offsetalator2 branch April 3, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice approved these changes

@vyasr vyasr vyasr approved these changes

@mythrocks mythrocks Awaiting requested review from mythrocks mythrocks is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

@divyegala divyegala Awaiting requested review from divyegala divyegala is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees

@davidwendt davidwendt

Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change strings strings issues (C++ and Python)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidwendt @vyasr @bdice