Use less _is_categorical_dtype #15148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
added
Python
bdice
approved these changes
Feb 27, 2024
Comment on lines
554
to
556
| # TODO: Remove this work-around Dictionary types | ||
| # in libcudf are fully mapped to categorical columns: | ||
| # https://github.com/rapidsai/cudf/issues/3960 |
There was a problem hiding this comment.
This linked issue has been resolved. Is there an action to be taken here (i.e. removal of the workaround)?
There was a problem hiding this comment.
It appears although the issue is closed, the latest PR that addressed this function notes that it's still awaiting libcudf handling of category type (#12571 (comment)) so I think this is still needed
vyasr
approved these changes
Feb 27, 2024
…ke/cudf into rm/_is_categorical_dtype
|
In bd7c126 I added a carve-out for |
galipremsagar
requested changes
Mar 21, 2024
Co-authored-by: GALI PREM SAGAR <[email protected]>
galipremsagar
approved these changes
Apr 10, 2024
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Rehash of #14942
Checklist