Replace _is_categorical_dtype with isinstance #14942
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
added
Python
galipremsagar
requested changes
Feb 1, 2024
Comment on lines
+970
to
+971
| dtype = cudf.dtype(dtype) | ||
| if isinstance(dtype, cudf.CategoricalDtype): |
There was a problem hiding this comment.
I think replacing _is_categorical_dtype calls else where with isinstance checks is the right thing but places like these where users can pass .astype('category'), we will need _is_categroical_dtype because doing a cudf.dtype('category') will lead to different behaviors:
In [1]: import cudf
In [2]: cudf.dtype("category")
Out[2]: CategoricalDtype(categories=None, ordered=None, categories_dtype=None)
|
Going to reopen this one with different changes so closing |
3 tasks
rapids-bot bot
pushed a commit
that referenced
this pull request
Apr 10, 2024
Rehash of #14942 Authors: - Matthew Roeschke (https://github.com/mroeschke) - Vyas Ramasubramani (https://github.com/vyasr) Approvers: - Bradley Dice (https://github.com/bdice) - Vyas Ramasubramani (https://github.com/vyasr) - GALI PREM SAGAR (https://github.com/galipremsagar) URL: #15148
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is more explicit than
_is_categorical_dtypewhich may allow array objects when we don't want toChecklist