Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable pandas pytests for cudf.pandas #15147

Merged
merged 47 commits into from
Mar 12, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
47 commits
Select commit Hold shift + click to select a range
fa89004
enable pandas tests
galipremsagar Feb 26, 2024
2122906
Merge branch 'branch-24.04' into enable_pandas_tests
galipremsagar Feb 28, 2024
621e570
Apply suggestions from code review
galipremsagar Feb 28, 2024
1940b26
Apply suggestions from code review
galipremsagar Feb 28, 2024
789bc13
Merge branch 'branch-24.04' into enable_pandas_tests
galipremsagar Feb 29, 2024
23b4de3
test
galipremsagar Feb 29, 2024
9d3e9cb
test
galipremsagar Feb 29, 2024
9138410
Merge branch 'branch-24.04' into enable_pandas_tests
galipremsagar Feb 29, 2024
e880e5c
Merge branch 'branch-24.04' into enable_pandas_tests
galipremsagar Mar 1, 2024
3f951cf
test
galipremsagar Mar 1, 2024
752d2d2
Update pr.yaml
galipremsagar Mar 1, 2024
9e3f1b2
Update .github/workflows/pr.yaml
galipremsagar Mar 1, 2024
636ad12
Update .github/workflows/test.yaml
galipremsagar Mar 1, 2024
2c65e72
skip all window pytests
galipremsagar Mar 1, 2024
241b870
Update run-pandas-tests.sh
galipremsagar Mar 1, 2024
5215c58
change scheduler
galipremsagar Mar 1, 2024
3427715
Merge branch 'enable_pandas_tests' of https://github.com/galipremsaga…
galipremsagar Mar 1, 2024
e074bb1
Merge branch 'branch-24.04' into enable_pandas_tests
galipremsagar Mar 1, 2024
526cb88
worksteal
galipremsagar Mar 1, 2024
cf6c7b0
Merge branch 'enable_pandas_tests' of https://github.com/galipremsaga…
galipremsagar Mar 1, 2024
615afce
Update run-pandas-tests.sh
galipremsagar Mar 4, 2024
de4b236
Merge branch 'branch-24.04' into enable_pandas_tests
galipremsagar Mar 4, 2024
52d4ef1
Merge branch 'branch-24.04' into enable_pandas_tests
galipremsagar Mar 4, 2024
0dd71ca
fix
galipremsagar Mar 4, 2024
0a94881
test
galipremsagar Mar 4, 2024
65ff0d8
Merge remote-tracking branch 'upstream/branch-24.04' into enable_pand…
galipremsagar Mar 4, 2024
bf52595
drop more dependencies
galipremsagar Mar 5, 2024
d5d54bb
drop more dependencies
galipremsagar Mar 5, 2024
19ad2ab
Merge remote-tracking branch 'upstream/branch-24.04' into enable_pand…
galipremsagar Mar 5, 2024
1f6b5ce
Update pyproject.toml
galipremsagar Mar 5, 2024
d704055
Merge branch 'branch-24.04' into enable_pandas_tests
galipremsagar Mar 5, 2024
34bba4d
merge
galipremsagar Mar 6, 2024
7686956
change
galipremsagar Mar 6, 2024
7a990cb
skip more
galipremsagar Mar 6, 2024
58b08ab
Merge remote-tracking branch 'upstream/branch-24.04' into enable_pand…
galipremsagar Mar 6, 2024
d2afb66
Merge branch 'branch-24.04' into enable_pandas_tests
galipremsagar Mar 11, 2024
0788c1c
enable
galipremsagar Mar 11, 2024
f13b450
Merge remote-tracking branch 'upstream/branch-24.04' into enable_pand…
galipremsagar Mar 11, 2024
990aaa1
add more
galipremsagar Mar 11, 2024
b0bce0a
more
galipremsagar Mar 12, 2024
4dc66bf
more
galipremsagar Mar 12, 2024
48e4853
Merge branch 'branch-24.04' into enable_pandas_tests
galipremsagar Mar 12, 2024
f83726b
Update run.sh
galipremsagar Mar 12, 2024
80e9798
Apply suggestions from code review
galipremsagar Mar 12, 2024
29b02df
Update dependencies.yaml
galipremsagar Mar 12, 2024
09dbe2f
Update run-pandas-tests.sh
galipremsagar Mar 12, 2024
c43d7b6
Update run.sh
galipremsagar Mar 12, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 12 additions & 13 deletions .github/workflows/pr.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ jobs:
- wheel-tests-dask-cudf
- devcontainer
- unit-tests-cudf-pandas
# - pandas-tests
- pandas-tests
#- pandas-tests-diff
#- pandas-tests-diff-comment
secrets: inherit
Expand Down Expand Up @@ -156,21 +156,20 @@ jobs:
secrets: inherit
uses: rapidsai/shared-workflows/.github/workflows/[email protected]
with:
# This selects "ARCH=amd64 + the latest supported Python + CUDA".
matrix_filter: map(select(.ARCH == "amd64")) | group_by(.CUDA_VER|split(".")|map(tonumber)|.[0]) | map(max_by([(.PY_VER|split(".")|map(tonumber)), (.CUDA_VER|split(".")|map(tonumber))]))
build_type: pull-request
script: ci/cudf_pandas_scripts/run_tests.sh
# pandas-tests:
# # run the Pandas unit tests using PR branch
# needs: wheel-build-cudf
# secrets: inherit
# uses: rapidsai/shared-workflows/.github/workflows/[email protected]
# with:
# matrix_filter: map(select(.ARCH == "amd64")) | max_by(.CUDA_VER) | [.]
# build_type: pull-request
# script: ci/cudf_pandas_scripts/pandas-tests/run.sh pr
# # Hide test failures because they exceed the GITHUB_STEP_SUMMARY output limit.
# test_summary_show: "none"
pandas-tests:
# run the Pandas unit tests using PR branch
needs: wheel-build-cudf
secrets: inherit
uses: rapidsai/shared-workflows/.github/workflows/[email protected]
with:
matrix_filter: map(select(.ARCH == "amd64")) | group_by(.CUDA_VER|split(".")|map(tonumber)|.[0]) | map(max_by([(.PY_VER|split(".")|map(tonumber)), (.CUDA_VER|split(".")|map(tonumber))]))
build_type: pull-request
script: ci/cudf_pandas_scripts/pandas-tests/run.sh pr
# Hide test failures because they exceed the GITHUB_STEP_SUMMARY output limit.
test_summary_show: "none"
#pandas-tests-diff:
# # diff the results of running the Pandas unit tests and publish a job summary
# needs: [pandas-tests-main, pandas-tests-pr]
Expand Down
24 changes: 12 additions & 12 deletions .github/workflows/test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -115,15 +115,15 @@ jobs:
date: ${{ inputs.date }}
sha: ${{ inputs.sha }}
script: ci/cudf_pandas_scripts/run_tests.sh
# pandas-tests:
# # run the Pandas unit tests
# secrets: inherit
# uses: rapidsai/shared-workflows/.github/workflows/[email protected]
# with:
# matrix_filter: map(select(.ARCH == "amd64")) | max_by(.CUDA_VER) | [.]
# build_type: nightly
# branch: ${{ inputs.branch }}
# date: ${{ inputs.date }}
# sha: ${{ inputs.sha }}
# # pr mode uses the HEAD of the branch, which is also correct for nightlies
# script: ci/cudf_pandas_scripts/pandas-tests/run.sh pr
pandas-tests:
# run the Pandas unit tests
secrets: inherit
uses: rapidsai/shared-workflows/.github/workflows/[email protected]
with:
matrix_filter: map(select(.ARCH == "amd64")) | group_by(.CUDA_VER|split(".")|map(tonumber)|.[0]) | map(max_by([(.PY_VER|split(".")|map(tonumber)), (.CUDA_VER|split(".")|map(tonumber))]))
build_type: nightly
branch: ${{ inputs.branch }}
date: ${{ inputs.date }}
sha: ${{ inputs.sha }}
# pr mode uses the HEAD of the branch, which is also correct for nightlies
script: ci/cudf_pandas_scripts/pandas-tests/run.sh pr
3 changes: 2 additions & 1 deletion ci/cudf_pandas_scripts/pandas-tests/run.sh
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,11 @@ mkdir -p "${RAPIDS_TESTS_DIR}"

bash python/cudf/cudf/pandas/scripts/run-pandas-tests.sh \
-n 10 \
--tb=line \
--tb=no \
-m "not slow" \
galipremsagar marked this conversation as resolved.
Show resolved Hide resolved
--max-worker-restart=3 \
--junitxml="${RAPIDS_TESTS_DIR}/junit-cudf-pandas.xml" \
--dist worksteal \
--report-log=${PANDAS_TESTS_BRANCH}.json 2>&1

# summarize the results and save them to artifacts:
Expand Down
7 changes: 5 additions & 2 deletions dependencies.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -717,8 +717,11 @@ dependencies:
packages:
# dependencies to run pandas tests
# https://github.com/pandas-dev/pandas/blob/main/environment.yml
# pandas[all] includes all of the required dependencies
- pandas[all]
# pandas[...] includes all of the required dependencies.
# Intentionally excluding `postgresql` because of
# installation issues with `psycopg2`.
- pandas[test, pyarrow, performance, computation, fss, excel, parquet, feather, hdf5, spss, html, xml, plot, output-formatting, clipboard, compression]
galipremsagar marked this conversation as resolved.
Show resolved Hide resolved
- pytest-reportlog
test_python_cudf_pandas:
common:
- output_types: pyproject
Expand Down
14 changes: 12 additions & 2 deletions python/cudf/cudf/pandas/scripts/run-pandas-tests.sh
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,18 @@ set -euo pipefail
# of Pandas installed.
PANDAS_VERSION=$(python -c "import pandas; print(pandas.__version__)")

PYTEST_IGNORES="--ignore=tests/io/test_user_agent.py --ignore=tests/interchange/test_impl.py --ignore=tests/window/test_dtypes.py --ignore=tests/strings/test_api.py --ignore=tests/window/test_numba.py"
PYTEST_IGNORES="--ignore=tests/io/test_user_agent.py \
--ignore=tests/interchange/test_impl.py \
--ignore=tests/window/test_dtypes.py \
--ignore=tests/strings/test_api.py \
--ignore=tests/window/test_numba.py \
--ignore=tests/window \
--ignore=tests/io/pytables \
--ignore=tests/plotting \
--ignore=tests/scalar \
--ignore=tests/series/test_arithmetic.py \
--ignore=tests/tslibs/test_parsing.py \
--ignore=tests/io/parser/common/test_read_errors.py"

mkdir -p pandas-testing
cd pandas-testing
Expand Down Expand Up @@ -185,7 +196,6 @@ and not test_numpy_ufuncs_basic[nullable_float-rad2deg]"
PANDAS_CI="1" python -m pytest -p cudf.pandas \
-v -m "not single_cpu and not db" \
-k "not test_overwrite_warns and not test_complex_series_frame_alignment and not test_to_parquet_gcs_new_file and not test_qcut_nat and not test_add and not test_ismethods and $TEST_NUMPY_UFUNCS_BASIC_FLAKY" \
--durations=50 \
--import-mode=importlib \
-o xfail_strict=True \
${PYTEST_IGNORES} \
Expand Down
5 changes: 3 additions & 2 deletions python/cudf/pyproject.toml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Copyright (c) 2021-2023, NVIDIA CORPORATION.
# Copyright (c) 2021-2024, NVIDIA CORPORATION.

[build-system]
build-backend = "scikit_build_core.build"
Expand Down Expand Up @@ -69,7 +69,8 @@ test = [
"tzdata",
] # This list was generated by `rapids-dependency-file-generator`. To make changes, edit ../../dependencies.yaml and run `rapids-dependency-file-generator`.
pandas-tests = [
"pandas[all]",
"pandas[test, pyarrow, performance, computation, fss, excel, parquet, feather, hdf5, spss, html, xml, plot, output-formatting, clipboard, compression]",
"pytest-reportlog",
] # This list was generated by `rapids-dependency-file-generator`. To make changes, edit ../../dependencies.yaml and run `rapids-dependency-file-generator`.
cudf-pandas-tests = [
"ipython",
Expand Down
Loading