Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable pandas pytests for cudf.pandas #15147

Merged
merged 47 commits into from
Mar 12, 2024

Conversation

galipremsagar
Copy link
Contributor

@galipremsagar galipremsagar commented Feb 26, 2024

Description

This PR enables cudf.pandas pandas pytest suite.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@galipremsagar galipremsagar requested a review from a team as a code owner February 26, 2024 22:55
@galipremsagar galipremsagar marked this pull request as draft February 26, 2024 22:55
@galipremsagar galipremsagar added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Feb 26, 2024
.github/workflows/pr.yaml Outdated Show resolved Hide resolved
.github/workflows/test.yaml Outdated Show resolved Hide resolved
@github-actions github-actions bot added the Python Affects Python cuDF API. label Feb 29, 2024
@github-actions github-actions bot added the ci label Mar 1, 2024
@galipremsagar galipremsagar marked this pull request as ready for review March 12, 2024 13:05
@galipremsagar galipremsagar requested a review from a team as a code owner March 12, 2024 13:05
@galipremsagar galipremsagar changed the title enable pandas tests Enable pandas pytests for cudf.pandas Mar 12, 2024
@galipremsagar galipremsagar self-assigned this Mar 12, 2024
dependencies.yaml Show resolved Hide resolved
python/cudf/cudf/pandas/scripts/run-pandas-tests.sh Outdated Show resolved Hide resolved
dependencies.yaml Outdated Show resolved Hide resolved
@galipremsagar galipremsagar requested a review from bdice March 12, 2024 15:21
Copy link
Contributor

@wence- wence- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the idea is that any tests that fail are non-fatal (and don't affect the overall workflow outcome), but any "other" failures (setup/whatever) are.

Do we have any observability over the level of pass/fail other than explicitly looking in the job log?

ci/cudf_pandas_scripts/pandas-tests/run.sh Show resolved Hide resolved
@galipremsagar
Copy link
Contributor Author

So the idea is that any tests that fail are non-fatal (and don't affect the overall workflow outcome), but any "other" failures (setup/whatever) are.

Yes, but I'm planning on adding the diff calculator for each of the test run in follow-up PRs. This PR just enables what we had disabled couple of weeks ago.

Do we have any observability over the level of pass/fail other than explicitly looking in the job log?

Right now, we have to look at test summary. But as I said above, after this PR merges I'll be enabling the diff calculation and commenting(if possible).

@wence-
Copy link
Contributor

wence- commented Mar 12, 2024

So the idea is that any tests that fail are non-fatal (and don't affect the overall workflow outcome), but any "other" failures (setup/whatever) are.

Yes, but I'm planning on adding the diff calculator for each of the test run in follow-up PRs. This PR just enables what we had disabled couple of weeks ago.

Do we have any observability over the level of pass/fail other than explicitly looking in the job log?

Right now, we have to look at test summary. But as I said above, after this PR merges I'll be enabling the diff calculation and commenting(if possible).

Thanks!

@galipremsagar galipremsagar added the 5 - Ready to Merge Testing and reviews complete, ready to merge label Mar 12, 2024
@galipremsagar
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit d48b904 into rapidsai:branch-24.04 Mar 12, 2024
75 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants