Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use appropriate make_offsets_child_column for building lists columns #15043

Merged
merged 2 commits into from
Feb 23, 2024

Conversation

davidwendt
Copy link
Contributor

Description

Fixes cudf::strings::extract_all() to use cudf::detail::make_offsets_child_column so it properly computes the output-size and checks for overflow when building offsets for a lists column.
Also undo some changes from #14745 that incorrectly called cudf::strings::detail::make_offsets_child_column to create offsets for a lists column.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added 2 - In Progress Currently a work in progress libcudf Affects libcudf (C++/CUDA) code. strings strings issues (C++ and Python) improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Feb 13, 2024
@davidwendt davidwendt self-assigned this Feb 13, 2024
@davidwendt davidwendt added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels Feb 14, 2024
@davidwendt davidwendt marked this pull request as ready for review February 14, 2024 20:30
@davidwendt davidwendt requested a review from a team as a code owner February 14, 2024 20:30
@davidwendt
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit ee3c769 into rapidsai:branch-24.04 Feb 23, 2024
68 checks passed
@davidwendt davidwendt deleted the extract-all-offsets branch February 23, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change strings strings issues (C++ and Python)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants