Use offsetalator in cudf::strings::findall #14745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidwendt
added
2 - In Progress
davidwendt
added
3 - Ready for Review
bdice
reviewed
Jan 26, 2024
cpp/src/strings/search/findall.cu
Outdated
| // Create indices vector with the total number of groups that will be extracted | ||
| auto const total_matches = | ||
| cudf::detail::get_value<size_type>(offsets->view(), strings_count, stream); | ||
| auto const sizes = count_matches(*d_strings, *d_prog, strings_count, stream, mr); //+1 |
There was a problem hiding this comment.
What does the //+1 mean here? I see previously the code passed strings_count + 1. Did the behavior change?
There was a problem hiding this comment.
Ah, good catch. That was left-over note-to-self. The +1 is not needed since the number of counts equals the strings_count. Previously we were storing the counts in an offsets column temporarily.
There was a problem hiding this comment.
Removed the comment here: ba0d432
davidwendt
changed the title
bdice
approved these changes
Jan 28, 2024
hyperbolic2346
approved these changes
Feb 1, 2024
|
/merge |
3 tasks
rapids-bot bot
pushed a commit
that referenced
this pull request
Feb 23, 2024
…15043) Fixes `cudf::strings::extract_all()` to use `cudf::detail::make_offsets_child_column` so it properly computes the output-size and checks for overflow when building offsets for a lists column. Also undo some changes from #14745 that incorrectly called `cudf::strings::detail::make_offsets_child_column` to create offsets for a lists column. Authors: - David Wendt (https://github.com/davidwendt) Approvers: - Bradley Dice (https://github.com/bdice) - Vyas Ramasubramani (https://github.com/vyasr) URL: #15043
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use
make_offsets_child_columnandoffsetalator_iteratorto build/access offsets instead of hardcoded types.This cleans up the code nicely by automatically handling offset overflow and computing the total number of matches.
Checklist